some non const reference removals

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/tiffimage_int.cpp

@@ -2055,9 +2055,10 @@ ByteOrder TiffParserWorker::decode(ExifData& exifData, IptcData& iptcData, XmpDa
 
 }  // TiffParserWorker::decode
 
-WriteMethod TiffParserWorker::encode(BasicIo& io, const byte* pData, size_t size, ExifData& exifData,
-                                     IptcData& iptcData, XmpData& xmpData, uint32_t root, FindEncoderFct findEncoderFct,
-                                     TiffHeaderBase* pHeader, OffsetWriter* pOffsetWriter) {
+WriteMethod TiffParserWorker::encode(BasicIo& io, const byte* pData, size_t size, const ExifData& exifData,
+                                     const IptcData& iptcData, const XmpData& xmpData, uint32_t root,
+                                     FindEncoderFct findEncoderFct, TiffHeaderBase* pHeader,
+                                     OffsetWriter* pOffsetWriter) {
   /*
      1) parse the binary image, if one is provided, and
      2) attempt updating the parsed tree in-place ("non-intrusive writing")

src/tiffimage_int.hpp

@@ -221,9 +221,9 @@ class TiffParserWorker {
        writing"). If there is a parsed tree, it is only used to access the
        image data in this case.
    */
-  static WriteMethod encode(BasicIo& io, const byte* pData, size_t size, ExifData& exifData, IptcData& iptcData,
-                            XmpData& xmpData, uint32_t root, FindEncoderFct findEncoderFct, TiffHeaderBase* pHeader,
-                            OffsetWriter* pOffsetWriter);
+  static WriteMethod encode(BasicIo& io, const byte* pData, size_t size, const ExifData& exifData,
+                            const IptcData& iptcData, const XmpData& xmpData, uint32_t root,
+                            FindEncoderFct findEncoderFct, TiffHeaderBase* pHeader, OffsetWriter* pOffsetWriter);
 
  private:
   /*!

src/tiffvisitor_int.cpp

@@ -444,10 +444,10 @@ void TiffDecoder::visitBinaryElement(TiffBinaryElement* object) {
   decodeTiffEntry(object);
 }
 
-TiffEncoder::TiffEncoder(ExifData& exifData, IptcData& iptcData, XmpData& xmpData, TiffComponent* pRoot,
+TiffEncoder::TiffEncoder(ExifData exifData, const IptcData& iptcData, const XmpData& xmpData, TiffComponent* pRoot,
                          bool isNewImage, PrimaryGroups pPrimaryGroups, const TiffHeaderBase* pHeader,
                          FindEncoderFct findEncoderFct) :
-    exifData_(exifData),
+    exifData_(std::move(exifData)),
     iptcData_(iptcData),
     xmpData_(xmpData),
     pHeader_(pHeader),

src/tiffvisitor_int.hpp

@@ -349,8 +349,9 @@ class TiffEncoder : public TiffVisitor {
            to, the image with the metadata to encode and a function to
            find special encoders.
    */
-  TiffEncoder(ExifData& exifData, IptcData& iptcData, XmpData& xmpData, TiffComponent* pRoot, bool isNewImage,
-              PrimaryGroups pPrimaryGroups, const TiffHeaderBase* pHeader, FindEncoderFct findEncoderFct);
+  TiffEncoder(ExifData exifData, const IptcData& iptcData, const XmpData& xmpData, TiffComponent* pRoot,
+              bool isNewImage, PrimaryGroups pPrimaryGroups, const TiffHeaderBase* pHeader,
+              FindEncoderFct findEncoderFct);
   TiffEncoder(const TiffEncoder&) = delete;
   TiffEncoder& operator=(const TiffEncoder&) = delete;
   //! Virtual destructor