Skip to content

Commit 89b8d4e

Browse files
committed
try to actually fix null pointer deref
Signed-off-by: Rosen Penev <[email protected]>
1 parent 25ef5d7 commit 89b8d4e

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/makernote_int.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,10 @@ TiffComponent* TiffMnCreator::create(uint16_t tag, IfdId group, const std::strin
142142
TiffComponent* TiffMnCreator::create(uint16_t tag, IfdId group, IfdId mnGroup) {
143143
auto tmr = std::find(std::begin(registry_), std::end(registry_), mnGroup);
144144
if (tmr != std::end(registry_)) {
145-
if (!tmr->newMnFct2_) {
146-
std::cout << "mnGroup = " << mnGroup << "\n";
145+
if (tmr->newMnFct2_) {
146+
return tmr->newMnFct2_(tag, group, mnGroup);
147147
}
148-
return tmr->newMnFct2_(tag, group, mnGroup);
148+
std::cout << "mnGroup = " << mnGroup << "\n";
149149
}
150150
return nullptr;
151151
} // TiffMnCreator::create

src/version.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,10 @@ static std::vector<std::string> getLoadedLibraries() {
123123
// enumerate loaded libraries and determine path to executable
124124
HMODULE handles[200];
125125
DWORD cbNeeded;
126-
if (EnumProcessModules(GetCurrentProcess(), handles, std::size(handles), &cbNeeded)) {
126+
if (EnumProcessModules(GetCurrentProcess(), handles, DWORD(std::size(handles)), &cbNeeded)) {
127127
char szFilename[_MAX_PATH];
128128
for (DWORD h = 0; h < cbNeeded / sizeof(handles[0]); h++) {
129-
GetModuleFileNameA(handles[h], szFilename, std::size(szFilename));
129+
GetModuleFileNameA(handles[h], szFilename, DWORD(std::size(szFilename)));
130130
std::string path(szFilename);
131131
pushPath(path, libs, paths);
132132
}

0 commit comments

Comments
 (0)