replace copy_n with constructor

No need for the former. Also remove some unnecessary 0 initialization.

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/pgfimage.cpp

@@ -254,8 +254,7 @@ DataBuf PgfImage::readPgfHeaderStructure(BasicIo& iIo, uint32_t& width, uint32_t
   if (bufRead != header.size())
     throw Error(ErrorCode::kerInputDataReadFailed);
 
-  DataBuf work(8);  // don't disturb the binary data - doWriteMetadata reuses it
-  std::copy_n(header.begin(), work.size(), work.begin());
+  DataBuf work(header.data(), 8);  // don't disturb the binary data - doWriteMetadata reuses it
   width = byteSwap_(work, 0, bSwap_);
   height = byteSwap_(work, 4, bSwap_);
 

src/types.cpp

@@ -94,8 +94,7 @@ size_t TypeInfo::typeSize(TypeId typeId) {
 DataBuf::DataBuf(size_t size) : pData_(size) {
 }
 
-DataBuf::DataBuf(const byte* pData, size_t size) : pData_(size) {
-  std::copy_n(pData, size, pData_.begin());
+DataBuf::DataBuf(const byte* pData, size_t size) : pData_(pData, pData + size) {
 }
 
 void DataBuf::alloc(size_t size) {