Skip to content

Commit a98954a

Browse files
committed
clang-tidy: add missing special member functions
Signed-off-by: Rosen Penev <[email protected]>
1 parent b4c90b5 commit a98954a

File tree

5 files changed

+12
-1
lines changed

5 files changed

+12
-1
lines changed

app/actions.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,10 @@ class TaskFactory {
9797
*/
9898
static TaskFactory& instance();
9999

100+
~TaskFactory() = default;
100101
//! Prevent copy construction: not implemented.
101102
TaskFactory(const TaskFactory&) = delete;
103+
TaskFactory& operator=(const TaskFactory&) = delete;
102104

103105
//! Destructor
104106
void cleanup();

app/exiv2app.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,9 @@ class Params : public Util::Getopt {
110110
static Params& instance();
111111

112112
//! Prevent copy-construction: not implemented.
113+
~Params() = default;
113114
Params(const Params&) = delete;
115+
Params& operator=(const Params&) = delete;
114116

115117
//! Enumerates print modes
116118
enum PrintMode {

include/exiv2/webpimage.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ class EXIV2API WebPImage : public Image {
5454
[[nodiscard]] std::string mimeType() const override;
5555
//@}
5656

57+
~WebPImage() = default;
5758
//! Copy constructor
5859
WebPImage(const WebPImage&) = delete;
5960
//! Assignment operator

src/crwimage_int.hpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,9 @@ class CiffDirectory : public CiffComponent {
330330
~CiffDirectory() override;
331331
//@}
332332

333+
CiffDirectory(const CiffDirectory&) = delete;
334+
CiffDirectory& operator=(const CiffDirectory&) = delete;
335+
333336
//! @name Manipulators
334337
//@{
335338
// Default assignment operator is fine
@@ -522,6 +525,7 @@ struct CrwMapping {
522525
*/
523526
class CrwMap {
524527
public:
528+
~CrwMap() = delete;
525529
//! @name Not implemented
526530
//@{
527531
CrwMap(const CrwMap&) = delete;

src/makernote_int.hpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ class TiffMnCreator {
8181
*/
8282
static TiffComponent* create(uint16_t tag, IfdId group, IfdId mnGroup);
8383

84+
~TiffMnCreator() = default;
8485
//! Prevent destruction (needed if used as a policy class)
85-
~TiffMnCreator() = delete;
86+
TiffMnCreator(const TiffComponent&) = delete;
87+
TiffMnCreator& operator=(const TiffComponent&) = delete;
8688

8789
private:
8890
static const TiffMnRegistry registry_[]; //<! List of makernotes

0 commit comments

Comments
 (0)