Eliminate some false positive results.

kevinbackhouse · kevinbackhouse · commit cb50787ec4e2 · 2022-07-07T12:56:12.000+01:00
diff --git a/.github/codeql-queries/exiv2-cpp-queries/unsafe_vector_access.ql b/.github/codeql-queries/exiv2-cpp-queries/unsafe_vector_access.ql
@@ -53,7 +53,7 @@ predicate indexK_with_fixedarray(ClassTemplateInstantiation t, ArrayIndexCall ca
     t.getSimpleName() = "array" and
     idx = call.getArgument(0) and
     lowerBound(idx) >= 0 and
-    upperBound(idx) < t.getTemplateArgument(1).(Literal).getValue().toInt()
+    upperBound(idx) < lowerBound(t.getTemplateArgument(1))
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ predicate indexK_with_fixedarray(ClassTemplateInstantiation t, ArrayIndexCall ca`
`53`	`53`	`t.getSimpleName() = "array" and`
`54`	`54`	`idx = call.getArgument(0) and`
`55`	`55`	`lowerBound(idx) >= 0 and`
`56`		`- upperBound(idx) < t.getTemplateArgument(1).(Literal).getValue().toInt()`
	`56`	`+ upperBound(idx) < lowerBound(t.getTemplateArgument(1))`
`57`	`57`	`)`
`58`	`58`	`}`
`59`	`59`