Skip to content

Commit 6fb7a44

Browse files
Magesh Chandramouliashishagg
authored andcommitted
Adding opentracing-spring-haystack-cloud-starter module (#84)
* updating README * cloud starter * including README * including README
1 parent 3d5d055 commit 6fb7a44

File tree

6 files changed

+66
-18
lines changed

6 files changed

+66
-18
lines changed

.travis/deploy.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,14 @@ if [ "${TRAVIS_BRANCH}" == 'master' -a "${TRAVIS_PULL_REQUEST}" == 'false' ] ||
99

1010
if [ ! -z "${TRAVIS_TAG}" ]; then
1111
echo "travis tag is set -> updating pom.xml <version> attribute to ${TRAVIS_TAG}"
12-
./mvnw --batch-mode --settings .travis/settings.xml --no-snapshot-updates -Prelease -DskipTests=true -DreleaseVersion=${TRAVIS_TAG} release:prepare
12+
./mvnw --batch-mode --settings .travis/settings.xml -DskipTests=true -DreleaseVersion=${TRAVIS_TAG} release:clean release:prepare release:perform
13+
SUCCESS=$?
1314
else
1415
echo "no travis tag is set, hence keeping the snapshot version in pom.xml"
16+
./mvnw --batch-mode --settings .travis/settings.xml clean deploy -DskipTests=true -B -U
17+
SUCCESS=$?
1518
fi
1619

17-
./mvnw --batch-mode --settings .travis/settings.xml -Prelease clean deploy -DskipTests=true -B -U
18-
SUCCESS=$?
1920
if [ ${SUCCESS} -eq 0 ]; then
2021
echo "successfully deployed the jars to nexus"
2122
fi

README.md

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,11 @@ For a full build, including unit tests you can run the following
3535

3636
Latest releases of this library are available in [Maven central](https://mvnrepository.com/search?q=Haystack&d=com.expedia)
3737

38-
1. Decide what kind of version bump is necessary, based on [Semantic Versioning](http://semver.org/) conventions.
39-
In the items below, the version number you select will be referred to as `x.y.z`.
40-
2. Update the [pom.xml](https://github.com/ExpediaDotCom/haystack-client-java/blob/master/pom.xml),
41-
changing the version element to `<version>x.y.z</version>`. Note the *removal* of the `-SNAPSHOT` suffix.
42-
3. Update the
43-
[ReleaseNotes.md]((https://github.com/ExpediaDotCom/haystack-client-java/blob/master/ReleaseNotes.md))
44-
file with details of your changes.
45-
5. Create a pull request with your changes.
46-
6. Ask for a review of the pull request; when it is approved, the Travis CI build will upload the resulting jar file
47-
to the [SonaType Staging Repository](https://oss.sonatype.org/#stagingRepositories).
48-
This will cause the jar file to be released to the
38+
1. Create a pull request with your changes.
39+
2. Ask for a review of the pull request; when it is approved, the Travis CI build will upload the resulting SNAPSHOT jar file
40+
to the [SonaType Staging Repository](https://oss.sonatype.org/#stagingRepositories)
41+
3. Once merged to master, one can use github https://github.com/ExpediaDotCom/haystack-client-java/releases or manual tagging to the next semantic version
42+
4. This will cause the build to run for the new tagged version. This will cause the jar files to be released to the
4943
[SonaType Release Repository](https://oss.sonatype.org/#nexus-search;quick~haystack-client-java).
50-
7. Now you have to *put back* the -SNAPSHOT that you removed in step 2. When you do that, bump the `z` value to `z + 1`
51-
to minimize the chance of somebody trying to release on top of the x.y.z version you just released. Note that the next
52-
release might not use `x.y.z+1`; it could instead be `x.y+1.0` or `x+1.0.0`
53-
8. Create another pull request with the change from step 7 and get it merged.
44+
5. Now, update the POM version to next snapshot version for development
45+
6. Create another pull request with the change from step 5 and get it merged.
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Check the [Quick Start](../opentracing-spring-haystack-web-starter#quick-start) section of the README file in [opentracing-spring-haystack-web-starter](../opentracing-spring-haystack-web-starter) module
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
2+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
3+
4+
<modelVersion>4.0.0</modelVersion>
5+
6+
<parent>
7+
<groupId>com.expedia.www</groupId>
8+
<artifactId>haystack-client-java-integrations</artifactId>
9+
<version>0.2.3-SNAPSHOT</version>
10+
</parent>
11+
12+
<artifactId>opentracing-spring-haystack-cloud-starter</artifactId>
13+
<packaging>jar</packaging>
14+
<name>opentracing-spring-haystack-cloud-starter</name>
15+
<description>Spring integration for haystack</description>
16+
17+
<properties>
18+
<opentracing-spring-cloud-starter.version>0.2.2</opentracing-spring-cloud-starter.version>
19+
</properties>
20+
21+
<dependencies>
22+
<dependency>
23+
<groupId>com.expedia.www</groupId>
24+
<artifactId>opentracing-spring-haystack-starter</artifactId>
25+
<version>${project.version}</version>
26+
</dependency>
27+
<dependency>
28+
<groupId>io.opentracing.contrib</groupId>
29+
<artifactId>opentracing-spring-cloud-starter</artifactId>
30+
<version>${opentracing-spring-cloud-starter.version}</version>
31+
</dependency>
32+
<dependency>
33+
<groupId>io.opentracing.contrib</groupId>
34+
<artifactId>opentracing-tracerresolver</artifactId>
35+
<version>0.1.5</version>
36+
</dependency>
37+
<dependency>
38+
<groupId>io.opentracing.contrib</groupId>
39+
<artifactId>opentracing-web-servlet-filter</artifactId>
40+
<version>0.2.2</version>
41+
</dependency>
42+
</dependencies>
43+
</project>

integrations/opentracing-spring-haystack-web-starter/README.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,16 @@ Add the following dependency to your application
4646
</dependency>
4747
```
4848

49+
Alternately, one can use `opentracing-spring-haystack-cloud-starter` instead. It is convenience starter that includes opentracing-spring-haystack-starter, opentracing-spring-web-starter and opentracing-spring-cloud-starter. This allows one to take advantage of opentracing instrumentation provided for Spring Cloud.
50+
51+
```xml
52+
<dependency>
53+
<groupId>com.expedia.www</groupId>
54+
<artifactId>opentracing-spring-haystack-cloud-starter</artifactId>
55+
<version>${opentracing-spring-haystack-cloud-starter.version}</version>
56+
</dependency>
57+
```
58+
4959
### Spring Application dependency
5060

5161
To access an instance of `opentracing.io.Tracer` to instrument a Spring application, one can add the following dependencies

integrations/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
<module>micrometer</module>
4545
<module>opentracing-spring-haystack-starter</module>
4646
<module>opentracing-spring-haystack-web-starter</module>
47+
<module>opentracing-spring-haystack-cloud-starter</module>
4748
<module>opencensus</module>
4849
</modules>
4950
</project>

0 commit comments

Comments
 (0)