removed synchronized constructs from some functions to improve performance

Author: ayansen

core/src/main/java/com/expedia/www/haystack/client/Span.java

@@ -99,18 +99,14 @@ Long getEndTime() {
    * @return the endTime
    */
   public Long getStartTime() {
-    synchronized (this) {
       return startTime;
-    }
   }
 
   /**
    * @return the tracer
    */
   public Tracer getTracer() {
-    synchronized (this) {
-      return this.tracer;
-    }
+    return this.tracer;
   }
 
   @Override
@@ -172,23 +168,17 @@ public Map<String, String> getBaggageItems() {
 
   @Override
   public Span setTag(String key, Number value) {
-    synchronized (this) {
-      return addTag(key, value);
-    }
+    return addTag(key, value);
   }
 
   @Override
   public Span setTag(String key, boolean value) {
-    synchronized (this) {
-      return addTag(key, value);
-    }
+    return addTag(key, value);
   }
 
   @Override
   public Span setTag(String key, String value) {
-    synchronized (this) {
-      return addTag(key, value);
-    }
+    return addTag(key, value);
   }
 
   public Map<String, Object> getTags() {
@@ -209,13 +199,6 @@ public Span log(long timestampMicroseconds, Map<String, ?> fields) {
     }
   }
 
-  @Override
-  public Span log(Map<String, ?> fields) {
-    synchronized (this) {
-      return log(System.nanoTime(), fields);
-    }
-  }
-
   @Override
   public Span log(long timestampMicroseconds, String event) {
     synchronized (this) {
@@ -228,11 +211,15 @@ public Span log(long timestampMicroseconds, String event) {
     }
   }
 
+  @Override
+  public Span log(Map<String, ?> fields) {
+    return log(System.nanoTime(), fields);
+  }
+
+
   @Override
   public Span log(String event) {
-    synchronized (this) {
-      return log(System.nanoTime(), event);
-    }
+    return log(System.nanoTime(), event);
   }
 
   public List<LogData> getLogs() {
@@ -256,13 +243,14 @@ private void finishedCheck(String format, Object... args) {
 
 
   private Span addTag(String key, Object value) {
-    if (key == null || value == null) {
+    synchronized (this) {
+      if (key == null || value == null) {
+        return this;
+      }
+      finishedCheck("Setting a tag (%s:%s) on a finished span", key, value);
+      tags.put(key, value);
       return this;
     }
-
-    finishedCheck("Setting a tag (%s:%s) on a finished span", key, value);
-    tags.put(key, value);
-    return this;
   }
 
   private void finishTrace(long finishMicros) {