Skip to content

Commit 92d7f5f

Browse files
Ashish AggarwalAshish Aggarwal
authored andcommitted
close the client during deregistration
1 parent a334516 commit 92d7f5f

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/HaystackTraceExporter.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ public class HaystackTraceExporter {
4242
@Nullable
4343
static SpanExporter.Handler handler = null;
4444

45+
@Nullable
46+
private static Client<Span> client = null;
4547

4648
private HaystackTraceExporter() {
4749
}
@@ -56,8 +58,8 @@ public static void createAndRegister(final DispatcherConfig dispatcherConfig,
5658
final Metrics metrics) {
5759
synchronized (monitor) {
5860
checkState(handler == null, "haystack exporter is already registered.");
59-
final Client<Span> dispatcher = buildRemoteClient(dispatcherConfig, metrics);
60-
final SpanExporter.Handler newHandler = new HaystackExporterHandler(dispatcher, serviceName, metrics);
61+
client = buildRemoteClient(dispatcherConfig, metrics);
62+
final SpanExporter.Handler newHandler = new HaystackExporterHandler(client, serviceName, metrics);
6163
HaystackTraceExporter.handler = newHandler;
6264
register(Tracing.getExportComponent().getSpanExporter(), newHandler);
6365
}
@@ -92,6 +94,10 @@ public static void unregister() {
9294
synchronized (monitor) {
9395
checkState(handler != null, "haystack exporter is not registered.");
9496
Tracing.getExportComponent().getSpanExporter().unregisterHandler(REGISTER_NAME);
97+
if (client != null) {
98+
client.close();
99+
client = null;
100+
}
95101
handler = null;
96102
}
97103
}

0 commit comments

Comments
 (0)