RL - Currently, in grpc client if an error throws it would be logged. However the error has a constructor where a throwable is passed as an argument. As a result, the {} in the message will never get replaced. The idea is to log the error in the simple message, as well as log the stack trace.

Author: rlau

core/src/main/java/com/expedia/www/haystack/client/dispatchers/clients/BaseGrpcClient.java

@@ -116,7 +116,7 @@ public void onCompleted() {
         @Override
         public void onError(Throwable t) {
             onErrorCounter.increment();
-            LOGGER.error("Dispatching span failed with error: {}", t);
+            LOGGER.error("Dispatching span failed with error: " + t, t);
         }
 
         @Override