Skip to content

Commit d9c72aa

Browse files
Merge pull request #74 from ExpediaDotCom/package-restructure-opencensus
restructure the package name for opencensus module
2 parents 2aa276c + d17e08b commit d9c72aa

File tree

8 files changed

+20
-24
lines changed

8 files changed

+20
-24
lines changed

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/HaystackExporterHandler.java renamed to integrations/opencensus/src/main/java/com/expedia/www/opencensus/exporter/trace/HaystackExporterHandler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace;
18+
package com.expedia.www.opencensus.exporter.trace;
1919

2020
import com.expedia.open.tracing.Log;
2121
import com.expedia.open.tracing.Tag;

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/HaystackTraceExporter.java renamed to integrations/opencensus/src/main/java/com/expedia/www/opencensus/exporter/trace/HaystackTraceExporter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace;
18+
package com.expedia.www.opencensus.exporter.trace;
1919

2020
import com.expedia.open.tracing.Span;
2121
import com.expedia.www.haystack.client.dispatchers.clients.Client;
2222
import com.expedia.www.haystack.client.dispatchers.clients.GRPCAgentProtoClient;
2323
import com.expedia.www.haystack.client.dispatchers.clients.HttpCollectorProtoClient;
2424
import com.expedia.www.haystack.client.metrics.Metrics;
2525
import com.expedia.www.haystack.client.metrics.NoopMetricsRegistry;
26-
import com.www.expedia.opencensus.exporter.trace.config.DispatcherConfig;
27-
import com.www.expedia.opencensus.exporter.trace.config.GrpcAgentDispatcherConfig;
28-
import com.www.expedia.opencensus.exporter.trace.config.HttpDispatcherConfig;
26+
import com.expedia.www.opencensus.exporter.trace.config.DispatcherConfig;
27+
import com.expedia.www.opencensus.exporter.trace.config.GrpcAgentDispatcherConfig;
28+
import com.expedia.www.opencensus.exporter.trace.config.HttpDispatcherConfig;
2929
import io.opencensus.trace.Tracing;
3030
import io.opencensus.trace.export.SpanExporter;
3131

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/config/DispatcherConfig.java renamed to integrations/opencensus/src/main/java/com/expedia/www/opencensus/exporter/trace/config/DispatcherConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace.config;
18+
package com.expedia.www.opencensus.exporter.trace.config;
1919

2020
import org.apache.commons.lang3.Validate;
2121

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/config/GrpcAgentDispatcherConfig.java renamed to integrations/opencensus/src/main/java/com/expedia/www/opencensus/exporter/trace/config/GrpcAgentDispatcherConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace.config;
18+
package com.expedia.www.opencensus.exporter.trace.config;
1919

2020
import org.apache.commons.lang3.Validate;
2121

integrations/opencensus/src/main/java/com/www/expedia/opencensus/exporter/trace/config/HttpDispatcherConfig.java renamed to integrations/opencensus/src/main/java/com/expedia/www/opencensus/exporter/trace/config/HttpDispatcherConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace.config;
18+
package com.expedia.www.opencensus.exporter.trace.config;
1919

2020
import org.apache.commons.lang3.Validate;
2121

integrations/opencensus/src/test/scala/com/www/expedia/opencensus/exporter/trace/HaystackExporterHandlerSpec.scala renamed to integrations/opencensus/src/test/scala/com/expedia/www/opencensus/exporter/trace/HaystackExporterHandlerSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace
19-
18+
package com.expedia.www.opencensus.exporter.trace
2019

2120
import java.util.Collections
2221

@@ -29,6 +28,7 @@ import io.opencensus.trace.{MessageEvent, Tracestate, _}
2928
import org.easymock.EasyMock
3029
import org.scalatest._
3130
import org.scalatest.easymock.EasyMockSugar
31+
3232
import scala.collection.JavaConverters._
3333

3434
class HaystackExporterHandlerSpec extends FunSpec with GivenWhenThen with Matchers with EasyMockSugar {

integrations/opencensus/src/test/scala/com/www/expedia/opencensus/exporter/trace/HaystackExporterIntegrationSpec.scala renamed to integrations/opencensus/src/test/scala/com/expedia/www/opencensus/exporter/trace/HaystackExporterIntegrationSpec.scala

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,14 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace
18+
package com.expedia.www.opencensus.exporter.trace
1919

20-
21-
import java.util
2220
import java.util.{Collections, Random}
2321

24-
import com.www.expedia.opencensus.exporter.trace.config.GrpcAgentDispatcherConfig
22+
import com.expedia.www.opencensus.exporter.trace.config.GrpcAgentDispatcherConfig
2523
import io.opencensus.trace._
2624
import io.opencensus.trace.samplers.Samplers
27-
import org.apache.kafka.clients.consumer.ConsumerConfig._
28-
import org.apache.kafka.clients.consumer.KafkaConsumer
25+
import org.apache.kafka.clients.consumer.{ConsumerConfig, KafkaConsumer}
2926
import org.apache.kafka.common.serialization.{ByteArrayDeserializer, StringDeserializer}
3027
import org.scalatest.{BeforeAndAfterAll, FunSpec, GivenWhenThen, Matchers}
3128

@@ -34,16 +31,15 @@ import scala.collection.JavaConverters._
3431
class HaystackExporterIntegrationSpec extends FunSpec with GivenWhenThen with Matchers with BeforeAndAfterAll {
3532
private val OPERATION_NAME = "/search"
3633
private val SERVICE_NAME = "my-service"
37-
private val START_TIME_MICROS = System.currentTimeMillis() * 1000
3834
private val MAX_DURATION_MILLIS = 10
3935
private var consumer: KafkaConsumer[String, Array[Byte]] = _
4036

4137
override def beforeAll(): Unit = {
4238
Thread.sleep(20000)
43-
val config: java.util.Map[String, Object] = new util.HashMap()
44-
config.put(BOOTSTRAP_SERVERS_CONFIG, "kafkasvc:9092")
45-
config.put(GROUP_ID_CONFIG, "integration_test")
46-
config.put(AUTO_OFFSET_RESET_CONFIG, "earliest")
39+
val config: java.util.Map[String, Object] = new java.util.HashMap()
40+
config.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, "kafkasvc:9092")
41+
config.put(ConsumerConfig.GROUP_ID_CONFIG, "integration_test")
42+
config.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest")
4743
consumer = new KafkaConsumer(config, new StringDeserializer(), new ByteArrayDeserializer())
4844
consumer.subscribe(Collections.singleton("proto-spans"))
4945
}
@@ -70,6 +66,7 @@ class HaystackExporterIntegrationSpec extends FunSpec with GivenWhenThen with Ma
7066
tracer.getCurrentSpan.putAttribute("error", AttributeValue.booleanAttributeValue(true))
7167
tracer.getCurrentSpan.addAnnotation("done searching",
7268
Collections.singletonMap("someevent", AttributeValue.longAttributeValue(200)))
69+
7370
} catch {
7471
case _: Exception =>
7572
tracer.getCurrentSpan.addAnnotation("Exception thrown when processing!")
@@ -102,7 +99,6 @@ class HaystackExporterIntegrationSpec extends FunSpec with GivenWhenThen with Ma
10299
protoSpan.getTraceId shouldEqual record.key()
103100
protoSpan.getServiceName shouldEqual SERVICE_NAME
104101
protoSpan.getOperationName shouldEqual OPERATION_NAME
105-
protoSpan.getStartTime should be >= START_TIME_MICROS
106102
protoSpan.getTagsCount shouldBe 5
107103
protoSpan.getTagsList.asScala.find(_.getKey == "span.kind").get.getVStr shouldEqual "server"
108104
protoSpan.getTagsList.asScala.find(_.getKey == "foo").get.getVStr shouldEqual "bar"

integrations/opencensus/src/test/scala/com/www/expedia/opencensus/exporter/trace/HaystackTraceExporterSpec.scala renamed to integrations/opencensus/src/test/scala/com/expedia/www/opencensus/exporter/trace/HaystackTraceExporterSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
*
1616
*/
1717

18-
package com.www.expedia.opencensus.exporter.trace
18+
package com.expedia.www.opencensus.exporter.trace
1919

20-
import com.www.expedia.opencensus.exporter.trace.config.{GrpcAgentDispatcherConfig, HttpDispatcherConfig}
20+
import com.expedia.www.opencensus.exporter.trace.config.{GrpcAgentDispatcherConfig, HttpDispatcherConfig}
2121
import org.scalatest.{FunSpec, GivenWhenThen, Matchers}
2222

2323
class HaystackTraceExporterSpec extends FunSpec with GivenWhenThen with Matchers {

0 commit comments

Comments
 (0)