Skip to content

Commit f02e108

Browse files
author
mdwairi
committed
fix: add missing toString
1 parent e5849c7 commit f02e108

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

expediagroup-sdk-openapi-plugin/src/main/kotlin/com/expediagroup/sdk/openapigenerator/task/GenerateEgSdkTask.kt

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,10 @@ abstract class GenerateEgSdkTask : DefaultTask() {
107107

108108
@TaskAction
109109
fun generate() {
110-
val supportingFilesNames = supportingTemplates.get().joinToString(",") { it.fileName }
110+
val supportingFilesNames = supportingTemplates.orNull
111+
?.joinToString(",") { it.fileName }
112+
.orEmpty()
113+
.ifEmpty { "false" }
111114

112115
val config =
113116
CodegenConfigurator().apply {
@@ -171,7 +174,7 @@ abstract class GenerateEgSdkTask : DefaultTask() {
171174
template.fileNameSuffix
172175
).also { t -> t.templateType = TemplateFileType.API }
173176
}
174-
} ?: emptyList()
177+
}
175178

176179
val resolvedSupportingTemplates =
177180
supportingTemplates.orNull?.let {
@@ -182,12 +185,12 @@ abstract class GenerateEgSdkTask : DefaultTask() {
182185
template.fileName
183186
)
184187
}
185-
} ?: emptyList()
188+
}
186189

187190
userDefinedTemplates(
188191
buildList {
189-
addAll(resolvedApiTemplates)
190-
addAll(resolvedSupportingTemplates)
192+
resolvedApiTemplates?.let { addAll(it) }
193+
resolvedSupportingTemplates?.let { addAll(it) }
191194
add(
192195
TemplateDefinition(
193196
"operation_params.mustache",

expediagroup-sdk-openapi-plugin/src/main/resources/templates/operations/params/get_path_params.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
return buildMap {
33
{{#pathParams}}
44
{{paramName}}{{^required}}?{{/required}}.also {
5-
put("{{{baseName}}}", {{{paramName}}}{{#isEnum}}.value{{/isEnum}})
5+
put("{{{baseName}}}", {{{paramName}}}{{#isEnum}}.value{{/isEnum}}{{^isString}}.toString(){{/isString}})
66
}
77
{{/pathParams}}
88
}

expediagroup-sdk-openapi-plugin/src/main/resources/templates/traits/implementation.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ override fun getUrlPath(): String {
1111
{{#pathParams}}
1212
url = url.replace(
1313
oldValue = "{" + "{{{baseName}}}" + "}",
14-
newValue = this.params.{{{paramName}}}{{#isEnum}}.value{{/isEnum}},
14+
newValue = this.params.{{{paramName}}}{{#isEnum}}.value{{/isEnum}}{{^isString}}.toString(){{/isString}},
1515
ignoreCase = true
1616
)
1717
{{/pathParams}}

0 commit comments

Comments
 (0)