Skip to content

Commit bd321be

Browse files
treypTrey Philips
andauthored
fix(approvals-satisfied): codeowners_overrides should replace existing patterns (#707)
Co-authored-by: Trey Philips <[email protected]>
1 parent 7f88f89 commit bd321be

19 files changed

+136
-626
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ Each of the following helpers are defined in a file of the same name in `src/hel
7474

7575
- Returns `true` if the PR has been approved by the specified GitHub team(s) or user(s) and `false` otherwise
7676
- If GitHub teams are omitted, uses `CODEOWNERS` to determine teams and/or users to use.
77-
- The parameter `codeowners_overrides` can be used to override entries from `CODEOWNERS`. It is a string formatted as comma-separated list of lines in [the `CODEOWNERS` syntax](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax). For example: `/path/foo @user1 @user2,/path/bar @user3`
77+
- The parameter `codeowners_overrides` can be used to override entries from `CODEOWNERS`. It is a string formatted as comma-separated list of lines in [the `CODEOWNERS` syntax](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-syntax). Exact pattern matches in CODEOWNERS will be replaced. Unmatched patterns will be appended.
78+
- example: `/path/foo @user1 @user2,/path/bar @user3`
7879
- Note: If you are providing teams in input, full team name is NOT needed. i.e. `team-name` works and `org/team-name` is NOT needed
7980

8081
### [approve-pr](.github/workflows/approve-pr.yml)

action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ inputs:
146146
description: 'A comma-separated list of team overrides which specify the number of required reviews per team (e.g. "@ExpediaGroup/team1:1,@ExpediaGroup/team2:2")'
147147
required: false
148148
codeowners_overrides:
149-
description: 'A comma-separated list of lines formatted in GitHub CODEOWNERS syntax which override the CODEOWNERS file (e.g. "/path/foo @user1 @user2,/path/bar @user3")'
149+
description: 'A comma-separated list of lines formatted in GitHub CODEOWNERS syntax which override the CODEOWNERS file (e.g. "/path/foo @user1 @user2,/path/bar @user3"). Exact pattern matches in CODEOWNERS will be replaced. Unmatched patterns will be appended.'
150150
required: false
151151
max_queue_size:
152152
description: 'The maximum number of PRs that can be in the merge queue at any given time'

dist/110.index.js

Lines changed: 17 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/110.index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/284.index.js

Lines changed: 1 addition & 588 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/284.index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/404.index.js

Lines changed: 17 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/404.index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/419.index.js

Lines changed: 17 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/419.index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)