fix(create-batched-commit-message): handle multiline commit messages (#732)

Author: danadajian

dist/813.index.js

@@ -27,12 +27,10 @@ export const createBatchedCommitMessage = () => {
   return eventPayload.commits
     .map(commit => {
       const prNumberWithParens = commit.message.match(/\(#(\d+)\)/)?.[0] ?? '';
-      const messageWithoutPrNumber = commit.message.replace(prNumberWithParens, '').trim();
+      const messageWithoutPrNumber = commit.message.replace(prNumberWithParens, '').split('\n')[0]?.trim() ?? '';
       const truncatedMessage = messageWithoutPrNumber.slice(0, maxCharactersPerMessage);
-      if (truncatedMessage.length < messageWithoutPrNumber.length) {
-        return `${truncatedMessage}... ${prNumberWithParens ?? 'PR unknown'}`;
-      }
-      return commit.message;
+      const ellipses = truncatedMessage.length < messageWithoutPrNumber.length ? '...' : '';
+      return `${truncatedMessage}${ellipses} ${prNumberWithParens}`;
     })
     .join(' and ');
 };

dist/813.index.js.map

@@ -40,7 +40,7 @@ describe('createBatchedCommitMessage', () => {
   });
 });
 
-describe('createBatchedCommitMessage', () => {
+describe('createBatchedCommitMessage long messages', () => {
   beforeEach(() => {
     context.payload.commits = [
       {
@@ -62,3 +62,24 @@ describe('createBatchedCommitMessage', () => {
     );
   });
 });
+
+describe('createBatchedCommitMessage multiline messages', () => {
+  beforeEach(() => {
+    context.payload.commits = [
+      {
+        id: '1234567890abcdef',
+        message: 'Fix a really really long issue \n' + '  \n' + '  * fix the issue\n' + '  \n' + '  * definitely fix the issue (#1)',
+        author: { name: 'John Doe', email: '' }
+      },
+      {
+        id: '1234567891abcdef',
+        message: 'Fix another really really long issue \n' + '  \n' + '  * fix the issue\n' + '  \n' + '  * definitely fix the issue (#2)',
+        author: { name: 'Jane Doe', email: '' }
+      }
+    ];
+  });
+  it('should truncate the message', () => {
+    const result = createBatchedCommitMessage();
+    expect(result).toBe('Fix a really really long issue (#1) and Fix another really really long issue (#2)');
+  });
+});