Skip to content

Commit 629f35d

Browse files
authored
[federation] update @key directive javadoc (#788)
Update Javadoc to clarify repeated directive issue (follow up to #787)
1 parent b22abfa commit 629f35d

File tree

1 file changed

+2
-1
lines changed
  • graphql-kotlin-federation/src/main/kotlin/com/expediagroup/graphql/federation/directives

1 file changed

+2
-1
lines changed

graphql-kotlin-federation/src/main/kotlin/com/expediagroup/graphql/federation/directives/KeyDirective.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ import graphql.introspection.Introspection.DirectiveLocation
2828
* well as all the corresponding federated (i.e. extended) types. Key fields specified in the directive field set should correspond to a valid field on the underlying GraphQL interface/object.
2929
* Federated extended types should also instrument all the referenced key fields with @external directive.
3030
*
31-
* NOTE: federation spec specifies that multiple @key directives can be applied on the field which is at odds with graphql-spec and currently unsupported by graphql-kotlin.
31+
* NOTE: The Federation spec specifies that multiple @key directives can be applied on the field. The GraphQL spec has been recently changed to allow this behavior,
32+
* but we are currently blocked and are tracking progress in [this issue](https://github.com/ExpediaGroup/graphql-kotlin/issues/590).
3233
*
3334
* Example:
3435
* Given

0 commit comments

Comments
 (0)