GraphQL client fixes (#709)

* client implements closeable
* fix GenerateClientMojo custom scalar parameter definition to match annotation

Author: dariuszkuc

graphql-kotlin-client/README.md

@@ -34,7 +34,7 @@ With Maven:
 With Gradle (example using kts):
 
 ```kotlin
-compile("com.expediagroup:graphql-kotlin-client:$latestVersion")
+implementation("com.expediagroup:graphql-kotlin-client:$latestVersion")
 ```
 
 ## Use it

graphql-kotlin-client/src/main/kotlin/com/expediagroup/graphql/client/GraphQLClient.kt

@@ -31,6 +31,7 @@ import io.ktor.client.request.post
 import io.ktor.http.ContentType
 import io.ktor.http.contentType
 import io.ktor.util.KtorExperimentalAPI
+import java.io.Closeable
 import java.net.URL
 
 /**
@@ -42,7 +43,7 @@ class GraphQLClient(
     private val mapper: ObjectMapper = jacksonObjectMapper(),
     engine: HttpClientEngineFactory<*> = CIO,
     vararg features: HttpClientFeature<*, *>
-) {
+) : Closeable {
     private val typeCache = mutableMapOf<Class<*>, JavaType>()
     init {
         mapper.enable(DeserializationFeature.READ_UNKNOWN_ENUM_VALUES_USING_DEFAULT_VALUE)
@@ -96,4 +97,8 @@ class GraphQLClient(
             mapper.typeFactory.constructParametricType(GraphQLResult::class.java, resultType)
         }
     }
+
+    override fun close() {
+        client.close()
+    }
 }

plugins/graphql-kotlin-maven-plugin/src/main/kotlin/com/expediagroup/graphql/plugin/maven/GenerateClientMojo.kt

@@ -74,7 +74,7 @@ class GenerateClientMojo : AbstractMojo() {
      * ```
      */
     @Parameter(name = "converters")
-    private var scalarConverters: Map<String, ScalarConverter> = emptyMap()
+    private var converters: Map<String, ScalarConverter> = emptyMap()
 
     /**
      * Directory file containing GraphQL queries, defaults to `src/main/resources`. Instead of specifying a directory you can
@@ -121,7 +121,7 @@ class GenerateClientMojo : AbstractMojo() {
         val config = GraphQLClientGeneratorConfig(
             packageName = packageName,
             allowDeprecated = allowDeprecatedFields,
-            scalarTypeToConverterMapping = scalarConverters.map { (key, value) -> key to ScalarConverterMapping(value.type, value.converter) }.toMap()
+            scalarTypeToConverterMapping = converters.map { (key, value) -> key to ScalarConverterMapping(value.type, value.converter) }.toMap()
         )
         generateClient(config, graphQLSchema, targetQueryFiles).forEach {
             it.writeTo(outputDirectory)