Upgrade to KotlinPoet v1.11.0, make corresponding required changes. (#1427)

### 📝 Description
This PR updates the KotlinPoet dependency version to `v1.11.0`. There are two breaking changes [in this version](https://github.com/square/kotlinpoet/releases/tag/1.11.0) that affect graphql-kotlin:
- KotlinPoet now enforces only allowed parameter modifiers in ParameterSpec (i.e. crossinline, vararg, and noinline). This required an actual fix in `GraphQLClientGenerator`.
- KotlinPoet now emits trailing commas for multi-line parameters and annotations.

In most cases the second change wouldn't be breaking, but because graphql-kotlin's test suite does an exact equality match against golden master queries, these started failing. Luckily regex can catch all these cases fairly easily.

### 🔗 Related Issues
This resolves #1426

### How tested?
- Ran `./gradlew check`

Author: bsorbo

gradle.properties

@@ -25,7 +25,7 @@ federationGraphQLVersion = 0.9.0
 graphQLJavaVersion = 18.0
 graphQLJavaDataLoaderVersion = 3.1.2
 jacksonVersion = 2.13.2
-kotlinPoetVersion = 1.10.2
+kotlinPoetVersion = 1.11.0
 ktorVersion = 2.0.0
 reactorVersion = 3.4.16
 reactorExtensionsVersion = 1.1.6

plugins/client/graphql-kotlin-client-generator/src/main/kotlin/com/expediagroup/graphql/plugin/client/generator/GraphQLClientGenerator.kt

@@ -161,7 +161,7 @@ class GraphQLClientGenerator(
                 operationTypeSpec.addProperty(variablesProperty)
 
                 val constructor = FunSpec.constructorBuilder()
-                    .addParameter("variables", variablesClassName, KModifier.OVERRIDE)
+                    .addParameter("variables", variablesClassName)
                     .build()
                 operationTypeSpec.primaryConstructor(constructor)
             }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/alias/AliasQuery.kt

@@ -26,6 +26,6 @@ public class AliasQuery : GraphQLClientRequest<AliasQuery.Result> {
     /**
      * Query that accepts some input arguments
      */
-    public val second: Boolean
+    public val second: Boolean,
   )
 }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/documentation/DocumentationQuery.kt

@@ -23,6 +23,6 @@ public class DocumentationQuery : GraphQLClientRequest<DocumentationQuery.Result
     /**
      * Query to test doc strings
      */
-    public val docQuery: DocObject
+    public val docQuery: DocObject,
   )
 }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/documentation/documentationquery/DocObject.kt

@@ -11,5 +11,5 @@ public data class DocObject(
   /**
    * An id with a comment containing % and $ as well
    */
-  public val id: Int
+  public val id: Int,
 )

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/include_skip_directives/IncludeSkipDirectivesQuery.kt

@@ -13,7 +13,7 @@ public const val INCLUDE_SKIP_DIRECTIVES_QUERY: String =
 
 @Generated
 public class IncludeSkipDirectivesQuery(
-  public override val variables: IncludeSkipDirectivesQuery.Variables
+  public override val variables: IncludeSkipDirectivesQuery.Variables,
 ) : GraphQLClientRequest<IncludeSkipDirectivesQuery.Result> {
   public override val query: String = INCLUDE_SKIP_DIRECTIVES_QUERY
 
@@ -25,7 +25,7 @@ public class IncludeSkipDirectivesQuery(
   @Generated
   public data class Variables(
     public val includeCondition: Boolean,
-    public val skipCondition: Boolean
+    public val skipCondition: Boolean,
   )
 
   @Generated
@@ -37,6 +37,6 @@ public class IncludeSkipDirectivesQuery(
     /**
      * Query that returns wrapper object with all supported scalar types
      */
-    public val scalarQuery: ScalarWrapper? = null
+    public val scalarQuery: ScalarWrapper? = null,
   )
 }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/include_skip_directives/includeskipdirectivesquery/ScalarWrapper.kt

@@ -11,5 +11,5 @@ public data class ScalarWrapper(
   /**
    * A signed 32-bit nullable integer value
    */
-  public val count: Int? = null
+  public val count: Int? = null,
 )

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/input_hard_coded/HardCodedInputQuery.kt

@@ -23,6 +23,6 @@ public class HardCodedInputQuery : GraphQLClientRequest<HardCodedInputQuery.Resu
     /**
      * Query that accepts some input arguments
      */
-    public val inputObjectQuery: Boolean
+    public val inputObjectQuery: Boolean,
   )
 }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/input_lists/InputListQuery.kt

@@ -11,7 +11,7 @@ public const val INPUT_LIST_QUERY: String =
 
 @Generated
 public class InputListQuery(
-  public override val variables: InputListQuery.Variables
+  public override val variables: InputListQuery.Variables,
 ) : GraphQLClientRequest<InputListQuery.Result> {
   public override val query: String = INPUT_LIST_QUERY
 
@@ -23,14 +23,14 @@ public class InputListQuery(
   public data class Variables(
     public val nullableIds: List<String?>? = null,
     public val nullableIdList: List<String>? = null,
-    public val nonNullableIds: List<String>
+    public val nonNullableIds: List<String>,
   )
 
   @Generated
   public data class Result(
     /**
      * Query accepting list input
      */
-    public val listInputQuery: String? = null
+    public val listInputQuery: String? = null,
   )
 }

plugins/client/graphql-kotlin-client-generator/src/test/data/generator/input_self_reference/SelfReferencingInputQuery.kt

@@ -12,7 +12,7 @@ public const val SELF_REFERENCING_INPUT_QUERY: String =
 
 @Generated
 public class SelfReferencingInputQuery(
-  public override val variables: SelfReferencingInputQuery.Variables
+  public override val variables: SelfReferencingInputQuery.Variables,
 ) : GraphQLClientRequest<SelfReferencingInputQuery.Result> {
   public override val query: String = SELF_REFERENCING_INPUT_QUERY
 
@@ -23,14 +23,14 @@ public class SelfReferencingInputQuery(
 
   @Generated
   public data class Variables(
-    public val input: ComplexArgumentInput? = null
+    public val input: ComplexArgumentInput? = null,
   )
 
   @Generated
   public data class Result(
     /**
      * Query that accepts self referencing input object
      */
-    public val complexInputObjectQuery: Boolean
+    public val complexInputObjectQuery: Boolean,
   )
 }