SDK-1399 accommodate running scenarios as tests by throwing exception… (#109)

Author: dtayeh

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/booking/AsyncSingleRoomBookScenario.java

@@ -1,5 +1,6 @@
 package com.expediagroup.sdk.rapid.examples.scenarios.booking;
 
+import com.expediagroup.sdk.core.model.Response;
 import com.expediagroup.sdk.rapid.examples.Constants;
 import com.expediagroup.sdk.rapid.examples.salesprofiles.RapidPartnerSalesProfile;
 import com.expediagroup.sdk.rapid.examples.scenarios.RapidScenario;
@@ -35,21 +36,22 @@ public void run() {
         logger.info("Async call - Getting property availability for test property: {}", Constants.TEST_PROPERTY_ID);
 
         shopService.asyncGetSingleRoomPropertiesAvailability(this.rapidPartnerSalesProfile)
-                .thenApply(response -> response.getData())
+                .thenApply(Response::getData)
                 .thenCompose(this::checkRoomPrices)
                 .thenCompose(this::bookRoom)
                 .thenCompose(this::getItinerary)
                 .thenAccept(itinerary -> {
-                    if (itinerary != null) {
-                        logger.info("Itinerary: {}", itinerary.getItineraryId());
+                    if (itinerary == null) {
+                        throw new IllegalStateException("Itinerary is null");
                     }
+                    logger.info("Itinerary: {}", itinerary.getItineraryId());
                 });
 
     }
 
     private CompletableFuture<Itinerary> getItinerary(ItineraryCreation itineraryCreation) {
         if (itineraryCreation == null) {
-            return CompletableFuture.completedFuture(null);
+            throw new IllegalStateException("ItineraryCreation is null");
         }
 
         logger.info("Booking Success. Itinerary id: {}", itineraryCreation.getItineraryId());
@@ -63,7 +65,7 @@ private CompletableFuture<Itinerary> getItinerary(ItineraryCreation itineraryCre
 
     private CompletableFuture<ItineraryCreation> bookRoom(RoomPriceCheck roomPriceCheck) {
         if (roomPriceCheck == null) {
-            return CompletableFuture.completedFuture(null);
+            throw new IllegalStateException("Room Price Check is null");
         }
 
         logger.info("Room Price Check: {}", roomPriceCheck.getStatus());
@@ -78,21 +80,22 @@ private CompletableFuture<ItineraryCreation> bookRoom(RoomPriceCheck roomPriceCh
 
     private CompletableFuture<RoomPriceCheck> checkRoomPrices(List<Property> propertyAvailabilityList) {
         if (propertyAvailabilityList == null || propertyAvailabilityList.isEmpty()) {
-            logger.error("No property availability found for the test property.");
-            return CompletableFuture.completedFuture(null);
+            throw new IllegalStateException("No property availability found for the test property.");
         }
 
         logger.info("Property Availability: {}", propertyAvailabilityList.get(0).getStatus());
 
         // Checking room prices for the property
         logger.info("Checking room prices for the property: {}...", Constants.TEST_PROPERTY_ID);
         Property property = propertyAvailabilityList.get(0);
-        if (property instanceof PropertyAvailability) {
-            PropertyAvailability propertyAvailability = (PropertyAvailability) property;
-            return shopService.asyncCheckRoomPrices(propertyAvailability, 0, 0)
-                    .thenApply(response -> response.getData());
-        } else {
-            return CompletableFuture.completedFuture(null);
+
+        if (!(property instanceof PropertyAvailability)) {
+            throw new IllegalStateException("Property is not an instance of PropertyAvailability");
         }
+        
+        PropertyAvailability propertyAvailability = (PropertyAvailability) property;
+        return shopService.asyncCheckRoomPrices(propertyAvailability, 0, 0)
+                .thenApply(response -> response.getData());
+
     }
 }

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/booking/CancelHeldBookingScenario.java

@@ -35,8 +35,7 @@ public void run() {
         List<Property> propertyAvailabilityList = shopService.getSingleRoomPropertiesAvailability(this.rapidPartnerSalesProfile).getData();
 
         if (propertyAvailabilityList == null || propertyAvailabilityList.isEmpty()) {
-            logger.error("No property availability found for the test property.");
-            return;
+            throw new IllegalStateException("No property availability found for the test property.");
         }
 
         logger.info("Property Availability: {}", propertyAvailabilityList.get(0).getStatus());
@@ -45,7 +44,7 @@ public void run() {
         logger.info("Checking room prices for the property: [{}]...", Constants.TEST_PROPERTY_ID);
         Property property = propertyAvailabilityList.get(0);
 
-        if (!(property instanceof PropertyAvailability)) throw new RuntimeException();
+        if (!(property instanceof PropertyAvailability)) throw new IllegalStateException("Property is not of type PropertyAvailability");
 
         PropertyAvailability propertyAvailability = (PropertyAvailability) property;
         RoomPriceCheck roomPriceCheck = shopService.checkRoomPrices(propertyAvailability, 0, 0).getData();

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/booking/MultiRoomHoldAndResumeBookScenario.java

@@ -42,8 +42,7 @@ public void run() {
         List<Property> propertyAvailabilityList = shopService.getMultipleRoomsPropertiesAvailability(this.rapidPartnerSalesProfile, occupancy).getData();
 
         if (propertyAvailabilityList == null || propertyAvailabilityList.isEmpty()) {
-            logger.error("No property availability found for the test property.");
-            return;
+            throw new IllegalStateException("No property availability found for the test property.");
         }
 
         logger.info("Property Availability found for property id: [{}] with status: [{}]",

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/booking/SingleRoomBookScenario.java

@@ -36,8 +36,7 @@ public void run() {
         List<Property> propertyAvailabilityList = shopService.getSingleRoomPropertiesAvailability(this.rapidPartnerSalesProfile).getData();
 
         if (propertyAvailabilityList == null || propertyAvailabilityList.isEmpty()) {
-            logger.error("No property availability found for the test property.");
-            return;
+            throw new IllegalStateException("No property availability found for the test property.");
         }
 
         logger.info("Property Availability: {}", propertyAvailabilityList.get(0).getStatus());

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/geography/GetRegionByAncestorIdScenario.java

@@ -28,8 +28,7 @@ public void run() {
             List<List<Region>> regionsPages = geographyService.getRegionsByAncestor(Constants.TEST_ANCESTOR_ID, this.rapidPartnerSalesProfile);
 
             if (regionsPages == null || regionsPages.isEmpty()) {
-                logger.error("No regions found for the ancestor id: [{}].", Constants.TEST_ANCESTOR_ID);
-                return;
+                throw new IllegalStateException(String.format("No regions found for the ancestor id: [%s].", Constants.TEST_ANCESTOR_ID));
             }
 
             logger.info("Regions found for the ancestor id: [{}]:", Constants.TEST_ANCESTOR_ID);

examples/src/main/java/com/expediagroup/sdk/rapid/examples/scenarios/shopping/GetAdditionalAvailabilityOfPropertyScenario.java

@@ -32,8 +32,7 @@ public void run() {
         List<Property> propertyAvailabilityList = shopService.getSingleRoomPropertiesAvailability(this.rapidPartnerSalesProfile).getData();
 
         if (propertyAvailabilityList == null || propertyAvailabilityList.isEmpty()) {
-            logger.error("No property availability found for the test property.");
-            return;
+            throw new IllegalStateException("No property availability found for the test property.");
         }
 
         logger.info("Property Availability: {}", propertyAvailabilityList.get(0).getStatus());

examples/src/main/java/com/expediagroup/sdk/rapid/examples/services/BookService.java

@@ -135,7 +135,7 @@ public Response<Nothing> cancelHeldReservationByItineraryId(ItineraryCreation it
         ItineraryCreationLinks itineraryCreationLinks = itineraryCreation.getLinks();
         if (itineraryCreationLinks == null) throw new RuntimeException();
         Link cancelLink = itineraryCreationLinks.getCancel();
-        if (cancelLink == null) throw new RuntimeException();
+        if (cancelLink == null) throw new IllegalStateException("Cancel link not found");
 
         DeleteHeldBookingOperationContext deleteHeldBookingOperationContext =
                 DeleteHeldBookingOperationContext.builder().customerIp("127.0.0.1").build();
@@ -150,7 +150,7 @@ public CompletableFuture<Response<Itinerary>> asyncGetReservationByItineraryId(I
         GetReservationByItineraryIdOperationContext getReservationByItineraryIdOperationContext =
                 GetReservationByItineraryIdOperationContext.builder().customerIp("127.0.0.1").build();
 
-        return rapidClient.executeAsync(new GetReservationByItineraryIdOperation(retrieveLink, getReservationByItineraryIdOperationContext  ));
+        return rapidClient.executeAsync(new GetReservationByItineraryIdOperation(retrieveLink, getReservationByItineraryIdOperationContext));
     }
 
     /* Helper methods */