Skip to content

Commit a557ecc

Browse files
authored
fix: update examples (#135)
1 parent 2e0417b commit a557ecc

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

.github/workflows/run-examples.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
if: ${{ inputs.sdk_key != '' }}
3939
with:
4040
repository: 'ExpediaGroup/rapid-java-sdk'
41+
ref: 'nanssari/fix_examples'
4142
- uses: actions/download-artifact@v4
4243
if: ${{ inputs.sdk_key != '' }}
4344
with:

examples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<java.version>1.8</java.version>
1212
<maven.compiler.source>1.8</maven.compiler.source>
1313
<maven.compiler.target>1.8</maven.compiler.target>
14-
<rapid-java-sdk.sdk.version>LATEST</rapid-java-sdk.sdk.version>
14+
<rapid-java-sdk.sdk.version>5.0.0-SNAPSHOT</rapid-java-sdk.sdk.version>
1515
</properties>
1616

1717
<repositories>

examples/src/main/java/com/expediagroup/sdk/rapid/examples/services/GeographyService.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import java.math.BigDecimal;
1515
import java.util.ArrayList;
1616
import java.util.Arrays;
17+
import java.util.Collections;
1718
import java.util.List;
1819

1920
/**
@@ -31,13 +32,13 @@ public List<List<Region>> getAllRegionsWithDetails(RapidPartnerSalesProfile rapi
3132
logger.info("------------- Calling getRegions paginated results with no ancestor ID and include=details to get all regions:");
3233

3334
GetRegionsOperationParams params = GetRegionsOperationParams.builder()
34-
.include(Arrays.asList("details"))
35+
.include(Collections.singletonList(GetRegionsOperationParams.Include.DETAILS))
3536
.language("en-US")
3637
.customerSessionId(Constants.CUSTOMER_SESSION_ID)
3738
.limit(BigDecimal.valueOf(10))
3839
.area("50,37.227924,-93.310036")
3940
.supplySource("expedia")
40-
.countryCode(Arrays.asList("US"))
41+
.countryCode(Collections.singletonList("US"))
4142
.build();
4243

4344
ResponsePaginator<List<Region>> responsePaginator = rapidClient.getPaginator(new GetRegionsOperation(params));
@@ -46,9 +47,7 @@ public List<List<Region>> getAllRegionsWithDetails(RapidPartnerSalesProfile rapi
4647

4748
logger.info("Paginator total results count: {}", responsePaginator.getPaginationTotalResults());
4849

49-
responsePaginator.forEachRemaining(page -> {
50-
pages.add(page.getData());
51-
});
50+
responsePaginator.forEachRemaining(page -> pages.add(page.getData()));
5251

5352
return pages;
5453
}
@@ -57,12 +56,12 @@ public List<List<Region>> getRegionsByAncestor(String ancestorId, RapidPartnerSa
5756
logger.info("------------- Calling getRegionsPaginator by ancestor ID: [{}]", ancestorId);
5857

5958
GetRegionsOperationParams params = GetRegionsOperationParams.builder()
60-
.include(Arrays.asList("details"))
59+
.include(Collections.singletonList(GetRegionsOperationParams.Include.DETAILS))
6160
.language("en-US")
6261
.customerSessionId(Constants.CUSTOMER_SESSION_ID)
6362
.limit(BigDecimal.valueOf(10))
6463
.supplySource("expedia")
65-
.countryCode(Arrays.asList("US"))
64+
.countryCode(Collections.singletonList("US"))
6665
.ancestorId(ancestorId)
6766
.build();
6867

@@ -72,9 +71,7 @@ public List<List<Region>> getRegionsByAncestor(String ancestorId, RapidPartnerSa
7271

7372
logger.info("Paginator total results count: {}", responsePaginator.getPaginationTotalResults());
7473

75-
responsePaginator.forEachRemaining(page -> {
76-
pages.add(page.getData());
77-
});
74+
responsePaginator.forEachRemaining(page -> pages.add(page.getData()));
7875

7976
return pages;
8077
}
@@ -83,7 +80,7 @@ public Region getRegionDetailsAndPropertyIds(String regionId, String language, R
8380
logger.info("------------- Calling GetRegion:");
8481

8582
GetRegionOperationParams params = GetRegionOperationParams.builder()
86-
.include(Arrays.asList("details", "property_ids"))
83+
.include(Arrays.asList(GetRegionOperationParams.Include.DETAILS, GetRegionOperationParams.Include.PROPERTY_IDS))
8784
.language(language)
8885
.regionId(regionId)
8986
.customerSessionId(Constants.CUSTOMER_SESSION_ID)

0 commit comments

Comments
 (0)