feat: validate operation params (#232)

Author: anssari1

customizations/generator/openapi/src/main/kotlin/com/expediagroup/sdk/generators/openapi/OpenApiSdkGenerator.kt

@@ -39,10 +39,7 @@ class OpenApiSdkGenerator {
             "pom.xml",
             "README.md",
             "ApiException.kt",
-            "LinkableOperation.kt",
-            "PropertyConstraintViolation.kt",
-            "PropertyConstraintsValidator.kt",
-            "PropertyConstraintViolationException.kt"
+            "LinkableOperation.kt"
         )
 
     companion object {
@@ -145,27 +142,6 @@ class OpenApiSdkGenerator {
                                     "ApiException.kt"
                                 )
                             )
-                            add(
-                                SupportingFile(
-                                    "validation/propertyConstraintViolationException.mustache",
-                                    "$packagePath/models/exception/",
-                                    "PropertyConstraintViolationException.kt"
-                                )
-                            )
-                            add(
-                                SupportingFile(
-                                    "validation/propertyConstraintViolation.mustache",
-                                    "$packagePath/models/exception/",
-                                    "PropertyConstraintViolation.kt"
-                                )
-                            )
-                            add(
-                                SupportingFile(
-                                    "validation/propertyConstraintsValidator.mustache",
-                                    "$packagePath/validation/",
-                                    "PropertyConstraintsValidator.kt"
-                                )
-                            )
 
                             add(
                                 TemplateDefinition(

customizations/generator/openapi/src/main/resources/templates/expediagroup-sdk/client.mustache

@@ -56,7 +56,6 @@ class {{clientClassname}}Client private constructor(clientConfiguration: RapidCl
             }
 
             appendHeaders(extraHeaders)
-            validateConstraints(operation.requestBody)
             contentType(ContentType.Application.Json)
             setBody(operation.requestBody)
         }
@@ -233,4 +232,4 @@ class {{clientClassname}}Client private constructor(clientConfiguration: RapidCl
             {{>client/paginatorMethods}}
         {{/isPaginatable}}
     {{/operation}}{{/operations}}{{/apis}}{{/apiInfo}}
-}
+}

customizations/generator/openapi/src/main/resources/templates/expediagroup-sdk/operation_params.mustache

@@ -3,12 +3,24 @@
         {{#hasNonBodyParams}}
             package com.expediagroup.sdk.{{namespace}}.operations
 
+            import com.expediagroup.sdk.core.model.exception.client.PropertyConstraintViolationException
             import com.expediagroup.sdk.core.model.OperationParams
+
             import com.fasterxml.jackson.annotation.JsonProperty
             import com.fasterxml.jackson.databind.annotation.JsonDeserialize
             import io.ktor.http.Headers
             import io.ktor.http.Parameters
 
+            import javax.validation.constraints.Max
+            import javax.validation.constraints.Min
+            import javax.validation.constraints.NotNull
+            import javax.validation.constraints.Pattern
+            import javax.validation.constraints.Size
+            import javax.validation.Valid
+            import javax.validation.Validation
+
+            import org.hibernate.validator.messageinterpolation.ParameterMessageInterpolator
+
             /**
             {{#nonBodyParams}}
                 {{#params}}
@@ -22,6 +34,7 @@
                 (
                     {{#nonBodyParams}}
                         {{#params}}
+                            {{>models/constraints}}
                             {{>modelMutable}} {{>client/apiParam}}{{^-last}}, {{/-last}}
                         {{/params}}
                     {{/nonBodyParams}}
@@ -31,6 +44,7 @@
                 internal constructor(
                     {{#nonBodyParams}}
                         {{#params}}
+                            {{>models/constraints}}
                             {{>modelMutable}} {{{paramName}}}: {{>partials/datatype}}? = null,
                         {{/params}}
                     {{/nonBodyParams}}
@@ -109,32 +123,36 @@
                     {{/nonBodyParams}}
 
                     fun build(): {{classname}}Params {
-                        {{#hasRequiredParams}}
-                            validateNullity()
-                        {{/hasRequiredParams}}
-
-                        return {{classname}}Params(
+                        val params = {{classname}}Params(
                             {{#nonBodyParams}}
                                 {{#params}}
                                     {{{paramName}}} = {{{paramName}}}{{#required}}!!{{/required}}{{^-last}},{{/-last}}
                                 {{/params}}
                             {{/nonBodyParams}}
                         )
+
+                        validate(params)
+
+                        return params
                     }
 
-                    {{#hasRequiredParams}}
-                        private fun validateNullity() {
-                            {{#nonBodyParams}}
-                                {{#params}}
-                                    {{#required}}
-                                        if ({{{paramName}}} == null) {
-                                            throw NullPointerException("Required parameter {{{paramName}}} is missing")
-                                        }
-                                    {{/required}}
-                                {{/params}}
-                            {{/nonBodyParams}}
+                    private fun validate(params: {{classname}}Params) {
+                        val validator =
+                            Validation
+                                .byDefaultProvider()
+                                .configure()
+                                .messageInterpolator(ParameterMessageInterpolator())
+                                .buildValidatorFactory()
+                                .validator
+
+                        val violations = validator.validate(params)
+
+                        if (violations.isNotEmpty()) {
+                            throw PropertyConstraintViolationException(
+                                constraintViolations = violations.map { "${it.propertyPath}: ${it.message}" }
+                            )
                         }
-                    {{/hasRequiredParams}}
+                    }
                 }
 
                 fun toBuilder() = Builder(
@@ -187,4 +205,4 @@
             }
         {{/hasNonBodyParams}}
     {{/operation}}
-{{/operations}}
+{{/operations}}