Skip to content

Commit 57a832b

Browse files
chore: fix verify-examples-and-tests action
1 parent e57a191 commit 57a832b

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.github/workflows/verify-examples-and-tests.yaml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,13 @@ jobs:
1616
java-version: '11'
1717
distribution: 'temurin'
1818
- name: verify examples
19+
env:
20+
XAP_KEY: "${{ secrets.API_KEY }}"
21+
XAP_SECRET: "${{ secrets.API_SECRET }}"
22+
VRBO_KEY: "${{ secrets.VRBO_KEY }}"
23+
VRBO_SECRET: "${{ secrets.VRBO_SECRET }}"
1924
run: |
20-
./gradlew :examples:run \
21-
-Dcom.expediagroup.xapjavasdk.apikey="${{ secrets.API_KEY }}" \
22-
-Dcom.expediagroup.xapjavasdk.apisecret="${{ secrets.API_SECRET }}" \
23-
-Dcom.expediagroup.xapjavasdk.vrbokey="${{ secrets.VRBO_KEY }}" \
24-
-Dcom.expediagroup.xapjavasdk.vrbosecret="${{ secrets.VRBO_SECRET }}" \
25+
./gradlew :examples:run
2526
2627
verify-integration-tests:
2728
runs-on: ubuntu-latest

examples/src/main/java/com/expediagroup/sdk/xap/examples/scenarios/XapScenario.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public interface XapScenario {
3434
* @return XapClient
3535
*/
3636
default XapClient createClient() {
37-
String key = System.getProperty("com.expediagroup.xapjavasdk.apikey");
38-
String secret = System.getProperty("com.expediagroup.xapjavasdk.apisecret");
37+
String key = System.getenv("XAP_KEY");
38+
String secret = System.getenv("XAP_SECRET");
3939

4040
BasicAuthCredentials credentials = new BasicAuthCredentials(key, secret);
4141

examples/src/main/java/com/expediagroup/sdk/xap/examples/scenarios/lodging/VrboScenario.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ public interface VrboScenario extends XapScenario {
3333
*/
3434
@Override
3535
default XapClient createClient() {
36-
String key = System.getProperty("com.expediagroup.xapjavasdk.vrbokey");
37-
String secret = System.getProperty("com.expediagroup.xapjavasdk.vrbosecret");
36+
String key = System.getenv("VRBO_KEY");
37+
String secret = System.getenv("VRBO_SECRET");
3838

3939
BasicAuthCredentials credentials = new BasicAuthCredentials(key, secret);
4040

0 commit comments

Comments
 (0)