Skip to content

Commit 960240d

Browse files
authored
Merge pull request #78822 from samranahm/78597/enable-scroll-on-welcome-modal
fix: Enable scroll view for migrated User welcome modal and other training modals
2 parents e5d1b7c + 4dcaac8 commit 960240d

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

src/components/AutoSubmitModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ function AutoSubmitModal() {
6767
onConfirm={onClose}
6868
titleStyles={[styles.mb1]}
6969
contentInnerContainerStyles={[styles.mb5]}
70+
shouldUseScrollView
7071
>
7172
{menuSections.map((section) => (
7273
<View

src/components/HoldOrRejectEducationalModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ function HoldOrRejectEducationalModal({onClose, onConfirm}: HoldOrRejectEducatio
7070
onClose={onClose}
7171
onConfirm={onConfirm}
7272
shouldGoBack={false}
73+
shouldUseScrollView
7374
>
7475
<>
7576
{menuSections.map((section) => (

src/components/HoldSubmitterEducationalModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ function HoldSubmitterEducationalModal({onClose, onConfirm}: HoldSubmitterEducat
3939
onConfirm={onConfirm}
4040
shouldCloseOnConfirm={false}
4141
shouldGoBack={false}
42+
shouldUseScrollView
4243
>
4344
<HoldMenuSectionList />
4445
</FeatureTrainingModal>

src/components/MigratedUserWelcomeModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ function MigratedUserWelcomeModal() {
114114
contentOuterContainerStyles={!shouldUseNarrowLayout && [styles.mt8, styles.mh8]}
115115
modalInnerContainerStyle={{...styles.pt0, ...(shouldUseNarrowLayout ? {} : styles.pb8)}}
116116
isModalDisabled={isModalDisabled}
117+
shouldUseScrollView
117118
>
118119
<View
119120
style={[styles.gap3, styles.pt1, styles.pl1]}

src/pages/ChangePolicyEducationalModal.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ function ChangePolicyEducationalModal() {
4040
contentInnerContainerStyles={[styles.mb5, styles.gap2]}
4141
onClose={onConfirm}
4242
onConfirm={onConfirm}
43+
shouldUseScrollView
4344
>
4445
<ChangeWorkspaceMenuSectionList />
4546
</FeatureTrainingModal>

0 commit comments

Comments
 (0)