[HOLD for payment 2023-11-02] [$500] Thread - Newly created thread report in Room remains in LHN if it is not commented on

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.86-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with any account.
3. On LHN, click on any Room and send a message.
4. Create a thread, don't comment.
5. Go back to LHN.

Expected Result:

The newly created thread does not appear.

Actual Result:

The newly created thread report remains in LHN if it is not commented on.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6241481_1697619572120.Room_newly_created_thread_appears_in_LHN_when_don_t_comment_it.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012abbff085af3a667
• Upwork Job ID: 1714592941457190912
• Last Price Increase: 2023-10-18
• Automatic offers:
• dukenv0307 | Contributor | 27293783

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~012abbff085af3a667

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[c3024]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty thread on a message in room appears in LHN

What is the root cause of that problem?

This here

App/src/libs/ReportUtils.js

Lines 3208 to 3209 in e8cb124

	if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !isChatRoom(report) && !isPolicyExpenseChat(report) && canHideReport) {
	return false;

return false for chats which are chat rooms. For threads created on a message in rooms also this !isChatRoom is false so the thread does not disappear from LHN

What changes do you think we should make in order to solve the problem?

We should check along with the above whether it is a room and also not a thread before returning false by changing the above check to

if (excludeEmptyChats && isEmptyChat && isChatReport(report) && !(isChatRoom(report) && !isThread(report)) && !(isPolicyExpenseChat(report) && !isThread(report)) && canHideReport) {
        return false;
    }

or

if (excludeEmptyChats && isEmptyChat && isChatReport(report) && (isThread(report) || (!isChatRoom(report) && !isPolicyExpenseChat(report))) && canHideReport) {
        return false;
    }

What alternative solutions did you explore? (Optional)

[conorpendergrast]

I've reproduced this too now

[dejavuwl]

I've reproduced this too now

What's your platform? I can't reproduce this now (Chrome Version 117.0.5938.149 (Official Build) (arm64), macOS 14.0).

[melvin-bot]

📣 @dejavuwl! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>