[Due for payment 2025-04-17] [$250] iOS - MC page appears briefly, blank recovery codes page when enabling 2FA via Xero option

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.11-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): applausetester+ck311255@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 16/iOS 18.3.1
App Component: Workspace Settings

Action Performed:

Precondition: Account is not validated before from Security >> 2FA)

1. Launch Hybrid app on iOS & log in
2. Create a new Workspace
3. Go to WS settings >> More Features >> Enable Accounting feature
4. Go to Accounting page
5. Select Xero option
6. Click on Enable 2FA authentication button

Expected Result:

Magic code page should appear for unvalidated account when enabling 2FA via Xero option

Actual Result:

Magic code appears briefly & suddenly blank recovery codes is displayed when enabling 2FA via Xero

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/df82f34a-4d0e-4685-af5a-7b109d470fee

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021901458894316675553
• Upwork Job ID: 1901458894316675553
• Last Price Increase: 2025-04-07

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The validate code modal disappears when we access it from 2FA required modal.

What is the root cause of that problem?

When we don't have 2FA enabled, the 2FA required modal will show.

App/src/components/ConnectToXeroFlow/index.native.tsx

Lines 42 to 47 in 69df56b

	{!is2FAEnabled && (
	<RequireTwoFactorAuthenticationModal
	onSubmit={() => {
	setIsRequire2FAModalOpen(false);
	Navigation.navigate(ROUTES.SETTINGS_2FA_ROOT.getRoute(ROUTES.POLICY_ACCOUNTING.getRoute(policyID), getXeroSetupLink(policyID)));
	}}

When pressing the button, it will navigate to the 2FA page, but also shows a validate code modal if the user isn't validated yet.

App/src/pages/settings/Security/TwoFactorAuth/CopyCodesPage.tsx

Line 55 in 69df56b

const [isValidateModalVisible, setIsValidateModalVisible] = useState(!isUserValidated);

I remember we had some issues on iOS where opening a 2nd modal from another modal will fail. In this case, the modal isn't immediately shown after the 1st modal, but I guess it has the same underlying issue.

What changes do you think we should make in order to solve the problem?

So, to solve it, we can apply the same solution, that is to wait until the modal closes first using Modal.close.

App/src/components/ConnectToXeroFlow/index.native.tsx

Lines 42 to 47 in 69df56b

	{!is2FAEnabled && (
	<RequireTwoFactorAuthenticationModal
	onSubmit={() => {
	setIsRequire2FAModalOpen(false);
	Navigation.navigate(ROUTES.SETTINGS_2FA_ROOT.getRoute(ROUTES.POLICY_ACCOUNTING.getRoute(policyID), getXeroSetupLink(policyID)));
	}}

close(() => Navigation.navigate(ROUTES.SETTINGS_2FA_ROOT.getRoute(ROUTES.POLICY_ACCOUNTING.getRoute(policyID), getXeroSetupLink(policyID))));

We can optionally do it if the user isn't validated yet, because if the user is already validated, there will be no validate code modal.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[RachCHopkins]

Very clear to repro.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021901458894316675553

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)