[NoQA] feat: cli setup to enable remote builds for ios and android using RNEF

[adhorodyski]

@mountiny

Explanation of Change

This PR replaces the Community CLI the app is using right now with its' successor, the RNEF's CLI.
This change enables consuming remote builds by CI/local environments that will be introduced in the followup PR.

This PR does not clear up the Community CLI from the project. This will be done as a separate effort, afterwards.

Value remoteCacheProvider: null is used to entirely skip checking against a remote cache for now in all environments. I'll soon be swapped with remoteCacheProvider: 'github-actions' for internal use and later on for all the contributors. We'll start producing remote artifacts in the meantime to secure a gradual rollout.

Before we merge:

• Verify MobileExpensify's patches on RN-CLI if they could all be removed. cc @staszekscp
• Verify contributingGuides/HYBRID_APP.md for updates. See what's missing and how we should adjust given that some of the tips are tied to @react-native-community/cli or manual pods installation.

Fixed Issues

$ #58743
PROPOSAL: https://expensify.slack.com/archives/C05LX9D6E07/p1740996271773479

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13486

Tests

All the below build configurations should pass just fine, for both Standalone and Hybrid apps.

1. npm run android-standalone
2. npm run android
3. npm run ios-standalone
4. npm run ios

Apart from these debug ones, all adhoc/release builds should pass correct as well.

Offline tests

QA Steps

Same as tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[adhorodyski]

The debug builds are passing for me so I'll proceed and undraft this PR - let the testing game begin 👨🏻‍🍳

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mateuuszzzzz]

@adhorodyski I checked a bullet point related to HybridApp

We had to make a few adjustments to community CLI in order to support our brownfield setup. Those changes were necessary to make commands like npx react-native run-ios or npx react-native run-android work.

If I read the code correctly, you removed all occurrences of old CLI from the project, so it should be safe to remove those patches permanently 😅

Regarding HYBRID_APP.md, the mention of an error thrown by the community CLI when pods are not installed is now outdated due to changes from this PR. Therefore, it can be removed along with the reference to the community CLI.

EDIT: I noticed that @react-native-community/cli-config is defined as dependency of rnef/cli. I would double-check that deletion of this patch won't break anything 🤞

[adhorodyski]

We had to make a few adjustments to community CLI in order to support our brownfield setup. Those changes were necessary to make commands like npx react-native run-ios or npx react-native run-android work.

Oki, if these now pass fine I'd assume (testing will confirm) we're good to remove them. Nice, some patches off the board!

Regarding HYBRID_APP.md, the mention of an error thrown by the community CLI when pods are not installed is now outdated due to changes from this PR. Therefore, it can be removed along with the reference to the community CLI.

I'll proceed and remove this then, thanks.

EDIT: I noticed that @react-native-community/cli-config is defined as dependency of rnef/cli. I would double-check that deletion of this patch won't break anything 🤞

So it worked fine up to this moment, I'll keep an eye on this and ideally eg. patch it upstream to allow for configurable paths.

@mateuuszzzzz thank you so much for chiming in, appreciate the time & effort taken 😊

[parasharrajat]

@adhorodyski There are some conflicts. Can You please merge main? I will start testing...

[roryabraham]

I'm not sure exactly what's causing the diff (probably the change to package.json), but you'll also want to merge main, run npm i, then run npm run gh-actions-build and commit the diff.

[adhorodyski]

I'm not sure exactly what's causing the diff (probably the change to package.json), but you'll also want to merge main, run npm i, then run npm run gh-actions-build and commit the diff.

This is passing now, thanks!

[adhorodyski]

@parasharrajat let's hold off a little, I'm figuring out why it's failing on my end now after merging with the latest main updates. Will update here.

EDIT: Both Android builds are passing now, looking into iOS ones.

[adhorodyski]

2 elements I'll continue working on tomorrow:

• Eslint setup that includes the rnef.config.mjs file
• Above error with the clean command. I know the root cause now, will likely have to patch the library. Discussing alternatives separately.

@roryabraham can I ask you to re-run the e2e suite? The tests should now run fine.

[roryabraham]

re-ran performance tests: https://github.com/Expensify/App/actions/runs/14204674861

[adhorodyski]

• I was able to verify the clean command was only my local problem (solved by git clean -fdx android/), checking this one off.

[adhorodyski]

Update:

• Builds and clean commands are passing on my end, @parasharrajat I'd have to ask you to retest them though since I have introduced some new changes 🙏🏻
• We can test E2Es as well, the previous run was failing really early on git merging
• Prettier runs fine and the config file is being handled as any other one in the project
• Eslint is not linting the config file, same way it does not run against any other configuration files (like metro). I'd advise to leave this as is, at least for now - it will rarely be a subject of change (if anytime). I played around with it but it's definitely not easy and requires changing TS globals and this can definitely lead to some regressions we're trying to avoid. @roryabraham please let me know if we can do nothing on this subject. I don't think we should block this PR on this one.

[parasharrajat]

Can we run performance tests on this PR?

I am curious to know how the automated tests are using the MOBILE-EXPENSIFY PR when it is not linked to the project yet.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[roryabraham]

Performance tests running: https://github.com/Expensify/App/actions/runs/14253373513

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.24-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[mvtglobally]

@adhorodyski @parasharrajat @roryabraham Is there anything to QA in Staging for this PR?

[parasharrajat]

@mvtglobally No

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[github-actions]

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅