[Due for payment 2025-04-14] [$250] Reports - Card list loads infinitely when search result is empty

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.16-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Search

Action Performed:

Precondition:

• User is workspace owner.
• Workspace has enabled Expensify Card.
• Workspace owner has assigned at least 9 cards to any member including the owner.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Click Filters icon.
4. Scroll down and click Card.
5. Enter term that will return no result.

Expected Result:

Card list will not load infinitely when search result is empty.

Actual Result:

Card list loads infinitely when search result is empty.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6777720_1742537605536.bandicam_2025-03-21_14-10-37-974.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021905103596968478280
• Upwork Job ID: 1905103596968478280
• Last Price Increase: 2025-03-27
• Automatic offers:
• daledah | Contributor | 106734732

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-21 06:57:34 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card list loads infinitely when search result is empty.

What is the root cause of that problem?

We always add the loading placeholder here

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersCardPage.tsx

Line 194 in c9c9d1e

showLoadingPlaceholder

What changes do you think we should make in order to solve the problem?

We can remove this props because we don't call any API or update any Onyx data

Or we can set it as !didScreenTransitionEnd && fetchStatus === 'loading' as we did with other search with fetchStatus from useOnyx

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can create a new variable noResultsFound like here when we make sectionshere

App/src/components/Search/SearchMultipleSelectionPicker.tsx

Line 49 in c9c9d1e

const {sections, noResultsFound} = useMemo(() => {

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MitchExpensify]

I don't even see the option to search anything here

[daledah]

Workspace owner has assigned at least 9 cards to any member including the owner.

@MitchExpensify as the precondition in OP, we need at least 9 cards

[MitchExpensify]

Ah I missed that, I don't have an account to reproduce that with

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021905103596968478280