[$250] Expense-Keep this one option doesn't resolve duplicates in track map expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.2.95-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76020
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Open workspace chat
3. Create 2 track map expense with same distance
4. Tap review duplicates - keep this one and complete the flow

Expected Result:

Keep this one option must resolve duplicate when review duplicates in track map expense.

Actual Result:

Keep this one option doesn't resolve duplicates when review duplicates in track map expense.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7043839_1767890775995.Screenrecorder-2026-01-08-22-02-52-800.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022010914303862970594
• Upwork Job ID: 2010914303862970594
• Last Price Increase: 2026-01-13

Issue Owner

Current Issue Owner: @amyevans

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keep this one option doesn't resolve duplicates in track map expense

What is the root cause of that problem?

1. The transactionIDList is missing in transactionsMergeParams passed to IOU.mergeDuplicates.
   

   App/src/pages/TransactionDuplicate/Confirmation.tsx

   Line 81 in 77aa31b

   IOU.mergeDuplicates(transactionsMergeParams);

2. The transactionIDList is missing because duplicates has the value undefined.
   

   App/src/pages/TransactionDuplicate/Confirmation.tsx

   Lines 70 to 73 in 77aa31b

   	const transactionsMergeParams = useMemo(
   	() => TransactionUtils.buildMergeDuplicatesParams(reviewDuplicates, duplicates ?? [], newTransaction),
   	[duplicates, reviewDuplicates, newTransaction],
   	);

3. duplicates is retrieved from useTransactionsByID.
   

   App/src/hooks/useTransactionsByID.ts

   Lines 13 to 20 in 77aa31b

   	const [transactions] = useOnyx(
   	ONYXKEYS.COLLECTION.TRANSACTION,
   	{
   	selector: transactionsSelector,
   	canBeMissing: true,
   	},
   	[transactionsSelector],
   	);

   
   However, since transactionIDs change too frequently, the transactionsSelector becomes a dependency of useOnyx and changes accordingly, causing the read and filter logic to be inaccurate.

What changes do you think we should make in order to solve the problem?

We should decouple the reading of ONYXKEYS.COLLECTION.TRANSACTION so that it does not depend on changes from the input.

App/src/hooks/useTransactionsByID.ts

Lines 13 to 20 in 77aa31b

	const [transactions] = useOnyx(
	ONYXKEYS.COLLECTION.TRANSACTION,
	{
	selector: transactionsSelector,
	canBeMissing: true,
	},
	[transactionsSelector],
	);

const [allTransactions] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION, {
    canBeMissing: true,
});
const transactions = useMemo(() => transactionsSelector(allTransactions), [transactionsSelector, allTransactions]);

What alternative solutions did you explore? (Optional)

N/A

[twinkle-react]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Keep this one" doesn't resolve duplicates for track map expenses. When selecting "Keep this one" and completing the flow, duplicates remain unresolved.

What is the root cause of that problem?

The root cause is that useTransactionsByID recreates transactionsSelector whenever transactionIDs changes, even when the array contents are the same (new array reference with identical IDs). This causes useOnyx to re-read unnecessarily and can result in stale or missing data when the selector is recreated during the read cycle.

In useTransactionsByID.ts:
useTransactionsByID.ts
Lines 7-20

function useTransactionsByID(transactionIDs: string[] | undefined) {
    const transactionsSelector = useCallback(
        (transactions: OnyxCollection<Transaction>) =>
            transactionIDs?.map((id) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]) ?? [],
        [transactionIDs],
    );

    const [transactions] = useOnyx(
        ONYXKEYS.COLLECTION.TRANSACTION,
        {
            selector: transactionsSelector,
            canBeMissing: true,
        },
        [transactionsSelector],
    );

When reviewDuplicates?.duplicates changes reference (same content), transactionIDs changes reference, transactionsSelector is recreated, and useOnyx re-reads with a potentially stale selector, leading to duplicates being undefined or incorrect.

What changes do you think we should make in order to solve the problem?

Stabilize the transactionIDs reference using useDeepCompareRef so the selector only recreates when the IDs actually change (deep equality), not on reference changes. This uses an existing Expensify utility and avoids unnecessary re-reads.

Update useTransactionsByID.ts:

import {useCallback} from 'react';
import type {OnyxCollection} from 'react-native-onyx';
import ONYXKEYS from '@src/ONYXKEYS';
import type {Transaction} from '@src/types/onyx';
import useDeepCompareRef from './useDeepCompareRef';
import useOnyx from './useOnyx';

function useTransactionsByID(transactionIDs: string[] | undefined) {
    const stableTransactionIDs = useDeepCompareRef(transactionIDs);

    const transactionsSelector = useCallback(
        (transactions: OnyxCollection<Transaction>) =>
            stableTransactionIDs?.map((id) => transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${id}`]) ?? [],
        [stableTransactionIDs],
    );

    const [transactions] = useOnyx(
        ONYXKEYS.COLLECTION.TRANSACTION,
        {
            selector: transactionsSelector,
            canBeMissing: true,
        },
        [transactionsSelector],
    );

    return [transactions];
}

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022010914303862970594

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)