Implement changes in other jobs too

Author: roryabraham

.github/actions/composite/checkoutRepoAndGitHubActions/action.yml

@@ -0,0 +1,27 @@
+name: Checkout target repo and GitHub Actions repo
+
+outputs:
+  NAME:
+    description: The target repo where this workflow is running (repo name w/o org prefix)
+    value: ${{ steps.repo.outputs.NAME }}
+
+runs:
+  using: composite
+  steps:
+    - name: Get target repo name
+      id: repo
+      run: echo "NAME=$(basename ${{ github.repository }})" >> "$GITHUB_OUTPUT"
+      shell: bash
+
+    # v4.2.2
+    - name: Checkout
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      with:
+        path: ${{ steps.repo.outputs.NAME }}
+
+    - name: Checkout Expensify/GitHub-Actions
+      uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      with:
+        repository: Expensify/GitHub-Actions
+        path: GitHub-Actions
+        ref: Rory-ValidateGitHubActionsAnyRepo

.github/scripts/actionlint.sh

@@ -14,7 +14,8 @@ readonly SCRIPT_DIR
 
 # To update the actionlint version, replace this file with the updated checksums file from the GitHub release
 readonly CHECKSUMS_FILE="$SCRIPT_DIR/actionlint_checksums.txt"
-readonly ACTIONLINT_PATH="$HOME/.local/bin/actionlint"
+readonly ACTIONLINT_PATH="$SCRIPT_DIR/actionlint"
+readonly REPO_ROOT="${REPO_ROOT:-.}"
 
 source "$SCRIPT_DIR/shellUtils.sh"
 
@@ -81,6 +82,7 @@ fi
 
 info "Linting workflows..."
 echo
+cd "$REPO_ROOT" || exit 1
 if ! "$ACTIONLINT_PATH" -color; then
     error "Workflows did not pass actionlint :("
     exit 1

.github/scripts/validateImmutableActionRefs.sh

@@ -6,6 +6,8 @@
 SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &>/dev/null && pwd)"
 readonly SCRIPT_DIR
 
+readonly REPO_ROOT="${REPO_ROOT:-.}"
+
 source "$SCRIPT_DIR/shellUtils.sh"
 
 title "Checking for mutable action references..."
@@ -14,13 +16,13 @@ ACTION_USAGES=""
 
 # Find yaml files - these can be either:
 # - workflows, which are always stored in .github/workflows, or
-WORKFLOWS="$(find .github/workflows -type f \( -name "*.yml" -o -name "*.yaml" \))"
+WORKFLOWS="$(find "$REPO_ROOT/.github/workflows" -type f \( -name "*.yml" -o -name "*.yaml" \))"
 if [[ -z "$WORKFLOWS" ]]; then
     warning "No workflows found. Did you remember to run this script from the root of a repository?" >&2
 fi
 
 # - action metadata files, which can be anywhere in the repo, but must be called action.yml or action.yaml
-ACTIONS="$(find . -type f \( -name "action.yml" -o -name "action.yaml" \))"
+ACTIONS="$(find "$REPO_ROOT" -type f \( -name "action.yml" -o -name "action.yaml" \))"
 if [[ -z "$ACTIONS" ]]; then
     warning "No workflows found. Did you remember to run this script from the root of a repository?" >&2
 fi

.github/workflows/validateActions.yml

@@ -10,30 +10,9 @@ jobs:
   validateSchemas:
     runs-on: ubuntu-latest
     steps:
-      - run: |
-          set -x
-          pwd
-          ls
-
-      # v4.2.2
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-        with:
-          path: main
-
-      - name: Checkout Expensify/GitHub-Actions
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-        with:
-          repository: Expensify/GitHub-Actions
-          path: GitHub-Actions
-          ref: Rory-ValidateGitHubActionsAnyRepo
-
-      - run: |
-          set -x
-          pwd
-          ls
-          ls main
-          tree -a GitHub-Actions
+      - name: Checkout repos
+        id: repo
+        uses: Expensify/GitHub-Actions/.github/composite/checkoutRepoAndGitHubActions@Rory-ValidateGitHubActionsAnyRepo
 
       # v4.3.0
       - name: Setup Node
@@ -44,26 +23,30 @@ jobs:
         run: npm i -g ajv-cli@5.0.0
 
       - name: Validate action and workflow schemas
-        run: bash -x GitHub-Actions/.github/scripts/validateWorkflowSchemas.sh
+        run: GitHub-Actions/.github/scripts/validateWorkflowSchemas.sh
         env:
-          REPO_ROOT: main
+          REPO_ROOT: ${{ steps.repo.outputs.NAME }}
 
   actionlint:
     runs-on: ubuntu-latest
     steps:
-      # v4.2.2
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - name: Checkout repos
+        id: repo
+        uses: Expensify/GitHub-Actions/.github/composite/checkoutRepoAndGitHubActions@Rory-ValidateGitHubActionsAnyRepo
 
       - name: Lint workflows with actionlint
-        run: .github/scripts/actionlint.sh
+        run: GitHub-Actions/.github/scripts/actionlint.sh
+        env:
+          REPO_ROOT: ${{ steps.repo.outputs.NAME }}
 
   validateImmutableActionRefs:
     runs-on: ubuntu-latest
     steps:
-      # v4.2.2
-      - name: Checkout
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
+      - name: Checkout repos
+        id: repo
+        uses: Expensify/GitHub-Actions/.github/composite/checkoutRepoAndGitHubActions@Rory-ValidateGitHubActionsAnyRepo
 
       - name: Validate actions refs are immutable
-        run: .github/scripts/validateImmutableActionRefs.sh
+        run: GitHub-Actions/.github/scripts/validateImmutableActionRefs.sh
+        env:
+          REPO_ROOT: ${{ steps.repo.outputs.NAME }}