Merge pull request #890 from Expensify/beaman-fixMapDomainIssue

Handle no email in `isValidEmail` check

Author: Beamanator

__tests__/Str-test.js

@@ -192,6 +192,12 @@ describe('Str.isValidEmail', () => {
         // TLD too long
         expect(Str.isValidEmail('a@a.abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijkl')).toBeFalsy();
     });
+
+    it('Handles undefined and null values gracefully', () => {
+        expect(Str.isValidEmail(undefined)).toBeFalsy();
+        expect(Str.isValidEmail(null)).toBeFalsy();
+        expect(Str.isValidEmail('')).toBeFalsy();
+    });
 });
 
 describe('Str.isValidPhoneFormat', () => {

lib/str.ts

@@ -406,6 +406,9 @@ const Str = {
      * @returns True if the string is an email
      */
     isValidEmail(str: string): boolean {
+        if (!str || typeof str !== 'string') {
+            return false;
+        }
         const unicodeVersion = Punycode.toUnicode(str);
         if (String(unicodeVersion).match(Constants.CONST.REG_EXP.EMOJI_RULE)) {
             return false;