Handle emails better

Author: Beamanator

__tests__/Str-test.js

@@ -113,6 +113,12 @@ describe('Str.sanitizeURL', () => {
 describe('Str.isValidEmail', () => {
     it('Correctly identifies valid emails', () => {
         expect(Str.isValidEmail('abc@gmail.com')).toBeTruthy();
+
+        // Real-world examples from production testing
+        expect(Str.isValidEmail('zz@gmail.com')).toBeTruthy();
+        expect(Str.isValidEmail('zz+1@gmail.com')).toBeTruthy();
+        expect(Str.isValidEmail('dabeamanator+20251120@gmail.com')).toBeTruthy();
+
         expect(Str.isValidEmail('test@gmail')).toBeFalsy();
         expect(Str.isValidEmail('@gmail.com')).toBeFalsy();
         expect(Str.isValidEmail('usernamelongerthan64charactersshouldnotworkaccordingtorfc822whichisusedbyphp@gmail.com')).toBeFalsy();
@@ -192,6 +198,12 @@ describe('Str.isValidEmail', () => {
         // TLD too long
         expect(Str.isValidEmail('a@a.abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijkl')).toBeFalsy();
     });
+
+    it('Handles undefined and null values gracefully', () => {
+        expect(Str.isValidEmail(undefined)).toBeFalsy();
+        expect(Str.isValidEmail(null)).toBeFalsy();
+        expect(Str.isValidEmail('')).toBeFalsy();
+    });
 });
 
 describe('Str.isValidPhoneFormat', () => {

lib/str.ts

@@ -406,7 +406,24 @@ const Str = {
      * @returns True if the string is an email
      */
     isValidEmail(str: string): boolean {
-        const unicodeVersion = Punycode.toUnicode(str);
+        // Return false if str is undefined, null, or not a string
+        if (!str || typeof str !== 'string') {
+            return false;
+        }
+        
+        // Safely convert to unicode using punycode, handling any errors
+        let unicodeVersion: string | undefined;
+        try {
+            unicodeVersion = Punycode.toUnicode(str);
+            // Ensure unicodeVersion is a valid string before using it
+            if (!unicodeVersion || typeof unicodeVersion !== 'string') {
+                unicodeVersion = str;
+            }
+        } catch (error) {
+            // If punycode conversion fails, fall back to original string
+            unicodeVersion = str;
+        }
+        
         if (String(unicodeVersion).match(Constants.CONST.REG_EXP.EMOJI_RULE)) {
             return false;
         }