Minor improvements

Author: fabioh8010

lib/Onyx.ts

@@ -819,7 +819,7 @@ function setCollection<TKey extends CollectionKeyBase, TMap>(collectionKey: TKey
 
     const skippableCollectionMemberIDs = OnyxUtils.getSkippableCollectionMemberIDs();
     if (skippableCollectionMemberIDs.size) {
-        resultCollection = Object.keys(resultCollection).reduce((result: OnyxInputKeyValueMapping, key) => {
+        resultCollection = newCollectionKeys.reduce((result: OnyxInputKeyValueMapping, key) => {
             try {
                 const [, collectionMemberID] = OnyxUtils.splitCollectionMemberKey(key, collectionKey);
                 // eslint-disable-next-line no-param-reassign

tests/unit/onyxTest.ts

@@ -1967,7 +1967,6 @@ describe('Onyx', () => {
             expect(testKeyValue).toEqual({
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry1`]: {id: 'entry1_id', name: 'entry1_name'},
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry2`]: {id: 'entry2_id', name: 'entry2_name'},
-                [`${ONYX_KEYS.COLLECTION.TEST_KEY}skippable-id`]: undefined,
             });
         });
 
@@ -1991,7 +1990,6 @@ describe('Onyx', () => {
             expect(testKeyValue).toEqual({
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry1`]: {id: 'entry1_id', name: 'entry1_name'},
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry2`]: {id: 'entry2_id', name: 'entry2_name'},
-                [`${ONYX_KEYS.COLLECTION.TEST_KEY}skippable-id`]: undefined,
             });
         });
 
@@ -2015,7 +2013,6 @@ describe('Onyx', () => {
             expect(testKeyValue).toEqual({
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry1`]: {id: 'entry1_id', name: 'entry1_name'},
                 [`${ONYX_KEYS.COLLECTION.TEST_KEY}entry2`]: {id: 'entry2_id', name: 'entry2_name'},
-                [`${ONYX_KEYS.COLLECTION.TEST_KEY}skippable-id`]: undefined,
             });
         });
     });

tests/unit/useOnyxTest.ts

@@ -675,7 +675,6 @@ describe('useOnyx', () => {
             expect(result.current[0]).toEqual({
                 [`${ONYXKEYS.COLLECTION.TEST_KEY}entry1`]: {id: 'entry1_id', name: 'entry1_name'},
                 [`${ONYXKEYS.COLLECTION.TEST_KEY}entry2`]: {id: 'entry2_id', name: 'entry2_name'},
-                [`${ONYXKEYS.COLLECTION.TEST_KEY}skippable-id`]: undefined,
             });
             expect(result.current[1].status).toEqual('loaded');
 
@@ -690,7 +689,6 @@ describe('useOnyx', () => {
             expect(result.current[0]).toEqual({
                 [`${ONYXKEYS.COLLECTION.TEST_KEY}entry1`]: {id: 'entry1_id', name: 'entry1_name_changed'},
                 [`${ONYXKEYS.COLLECTION.TEST_KEY}entry2`]: {id: 'entry2_id', name: 'entry2_name_changed'},
-                [`${ONYXKEYS.COLLECTION.TEST_KEY}skippable-id`]: undefined,
             });
             expect(result.current[1].status).toEqual('loaded');
         });