[fix] Prevent style recalculation on pageload

natew · necolas · commit 59af091fdb4d · 2022-07-02T11:12:55.000-07:00
Close necolas#2325
diff --git a/packages/react-native-web/src/exports/Dimensions/index.js b/packages/react-native-web/src/exports/Dimensions/index.js
@@ -45,8 +45,14 @@ const dimensions = {
 };
 const listeners = {};
 
+let shouldInit = canUseDOM;
+
 export default class Dimensions {
   static get(dimension: DimensionKey): DisplayMetrics {
+    if (shouldInit) {
+      shouldInit = false;
+      Dimensions._update();
+    }
     invariant(dimensions[dimension], `No dimension set for key ${dimension}`);
     return dimensions[dimension];
   }
@@ -118,6 +124,5 @@ export default class Dimensions {
 }
 
 if (canUseDOM) {
-  Dimensions._update();
   window.addEventListener('resize', Dimensions._update, false);
 }

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,14 @@ const dimensions = {`
`45`	`45`	`};`
`46`	`46`	`const listeners = {};`
`47`	`47`
	`48`	`+let shouldInit = canUseDOM;`
	`49`	`+`
`48`	`50`	`export default class Dimensions {`
`49`	`51`	`static get(dimension: DimensionKey): DisplayMetrics {`
	`52`	`+ if (shouldInit) {`
	`53`	`+ shouldInit = false;`
	`54`	`+ Dimensions._update();`
	`55`	`+ }`
`50`	`56`	invariant(dimensions[dimension], `No dimension set for key ${dimension}`);
`51`	`57`	`return dimensions[dimension];`
`52`	`58`	`}`
`@@ -118,6 +124,5 @@ export default class Dimensions {`
`118`	`124`	`}`
`119`	`125`
`120`	`126`	`if (canUseDOM) {`
`121`		`- Dimensions._update();`
`122`	`127`	`window.addEventListener('resize', Dimensions._update, false);`
`123`	`128`	`}`