Skip to content

Commit 17565e4

Browse files
cortinicororyabraham
authored andcommitted
Fix test_buck by providing exported deps for textinput target (facebook#34436)
Summary: This is an attempt to fix the broken `test_buck` as the `/textinput` target now needs to access the Kotlin stdlib dependencies ## Changelog [Internal] - Fix test_buck by providing exported deps for textinput target Pull Request resolved: facebook#34436 Test Plan: Will wait for a CircleCI result Reviewed By: cipolleschi Differential Revision: D38782473 Pulled By: cortinico fbshipit-source-id: 72265c34092372189d75df732b64a1e370453472
1 parent 38b5250 commit 17565e4

File tree

1 file changed

+5
-2
lines changed
  • ReactAndroid/src/main/java/com/facebook/react/views/textinput

1 file changed

+5
-2
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/textinput/BUCK

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_target", "rn_android_library")
1+
load("//tools/build_defs/oss:rn_defs.bzl", "IS_OSS_BUILD", "YOGA_TARGET", "react_native_android_toplevel_dep", "react_native_dep", "react_native_target", "rn_android_library")
2+
3+
# TODO(T115916830): Remove when Kotlin files are used in this module
4+
KOTLIN_STDLIB_DEPS = [react_native_android_toplevel_dep("third-party/kotlin:kotlin-stdlib")] if IS_OSS_BUILD else []
25

36
rn_android_library(
47
name = "textinput",
@@ -33,7 +36,7 @@ rn_android_library(
3336
react_native_target("java/com/facebook/react/common/mapbuffer:mapbuffer"),
3437
react_native_target("java/com/facebook/react/views/view:view"),
3538
react_native_target("java/com/facebook/react/config:config"),
36-
],
39+
] + KOTLIN_STDLIB_DEPS,
3740
exported_deps = [
3841
react_native_dep("third-party/android/androidx:appcompat"),
3942
],

0 commit comments

Comments
 (0)