Skip to content

Commit ea34ef7

Browse files
committed
Fix Java compilation errors from bad merge
1 parent 5a922f4 commit ea34ef7

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/MaintainVisibleScrollPositionHelper.java

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import com.facebook.react.bridge.UIManagerListener;
1919
import com.facebook.react.bridge.UiThreadUtil;
2020
import com.facebook.react.uimanager.UIManagerHelper;
21+
import com.facebook.react.uimanager.common.UIManagerType;
2122
import com.facebook.react.uimanager.common.ViewUtil;
2223
import com.facebook.react.views.scroll.ReactScrollViewHelper.HasSmoothScroll;
2324
import com.facebook.react.views.view.ReactViewGroup;
@@ -89,6 +90,14 @@ public void stop() {
8990
* been updated.
9091
*/
9192
public void updateScrollPosition() {
93+
// On Fabric this will be called internally in `didMountItems`.
94+
if (ViewUtil.getUIManagerType(mScrollView.getId()) == UIManagerType.FABRIC) {
95+
return;
96+
}
97+
updateScrollPositionInternal();
98+
}
99+
100+
private void updateScrollPositionInternal() {
92101
if (mConfig == null || mFirstVisibleView == null || mPrevFirstVisibleFrame == null) {
93102
return;
94103
}
@@ -169,6 +178,16 @@ public void run() {
169178
});
170179
}
171180

181+
@Override
182+
public void willMountItems(UIManager uiManager) {
183+
computeTargetView();
184+
}
185+
186+
@Override
187+
public void didMountItems(UIManager uiManager) {
188+
updateScrollPositionInternal();
189+
}
190+
172191
@Override
173192
public void didDispatchMountItems(UIManager uiManager) {
174193
// noop

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollViewManager.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -333,16 +333,6 @@ public void setMaintainVisibleContentPosition(ReactScrollView view, ReadableMap
333333
}
334334
}
335335

336-
@ReactProp(name = "maintainVisibleContentPosition")
337-
public void setMaintainVisibleContentPosition(ReactScrollView view, ReadableMap value) {
338-
if (value != null) {
339-
view.setMaintainVisibleContentPosition(
340-
MaintainVisibleScrollPositionHelper.Config.fromReadableMap(value));
341-
} else {
342-
view.setMaintainVisibleContentPosition(null);
343-
}
344-
}
345-
346336
@Override
347337
public Object updateState(
348338
ReactScrollView view, ReactStylesDiffMap props, StateWrapper stateWrapper) {

0 commit comments

Comments
 (0)