Fix OSBot accounts with special chars in password / spaces in name

Fix scripts with special chars / spaces in parameters
Fix update message shown when running manager outside of .jar

Author: Explv

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>org.explv.explv_osbot_manager</groupId>
     <artifactId>explv_osbot_manager</artifactId>
-    <version>v2.0.1</version>
+    <version>v2.0.3</version>
     <repositories>
         <repository>
             <id>local-repo</id>

src/main/java/bot_parameters/account/OSBotAccount.java

@@ -16,6 +16,6 @@ public static OSBotAccount getInstance() {
 
     @Override
     public final String[] toParameter() {
-        return new String[]{ "-login", String.format("%s:%s", getUsername(), getPassword()) };
+        return new String[]{ "-login", String.format("\"%s\":\"%s\"", getUsername(), getPassword()) };
     }
 }

src/main/java/bot_parameters/script/Script.java

@@ -47,7 +47,11 @@ public final void setParameters(final String parameters) {
 
     @Override
     public final String[] toParameter() {
-        return new String[] { "-script", String.format("%s:%s", scriptIdentifier.get(), parameters.get()) };
+        if (isLocal()) {
+            return new String[]{"-script", String.format("\\\"%s\\\":\\\"%s\\\"", scriptIdentifier.get(), parameters.get())};
+        } else {
+            return new String[]{"-script", String.format("%s:\\\"%s\\\"", scriptIdentifier.get(), parameters.get())};
+        }
     }
 
     private void writeObject(ObjectOutputStream stream) throws IOException {

src/main/java/main/ExplvOSBotManager.java

@@ -11,13 +11,18 @@ public static void main(final String[] args) {
         launch(args);
     }
 
+    public static final String getVersion() {
+        String version = ExplvOSBotManager.class.getPackage().getImplementationVersion();
+        return version != null ? version : "";
+    }
+
     @Override
     public final void start(final Stage primaryStage) {
         if (Updater.isUpdateRequired()) {
             Updater.update();
         }
 
-        primaryStage.setTitle("Explv's OSBot Manager");
+        primaryStage.setTitle("Explv's OSBot Manager " + getVersion());
         Scene scene = new Scene(new ManagerPane(), 600, 400);
         scene.getStylesheets().add("css/manager_pane.css");
         primaryStage.setScene(scene);

src/main/java/main/Updater.java

@@ -52,21 +52,26 @@ private static Optional<JSONObject> getLatestReleaseJSON() {
     }
 
     public static boolean isUpdateRequired() {
-        String currentVersion = Updater.class.getPackage().getImplementationVersion();
-        return !currentVersion.equals(latestReleaseJSON.get("tag_name"));
+        String currentVersion = ExplvOSBotManager.getVersion();
+
+        if (currentVersion.isEmpty()) {
+            return false;
+        }
+
+        return currentVersion.compareTo((String) latestReleaseJSON.get("tag_name")) < 0;
     }
 
     public static void update() {
         Dialog updateDialog = new Dialog();
-        updateDialog.setTitle("Explv's OSBot Manager");
+        updateDialog.setTitle("Explv's OSBot Manager " + ExplvOSBotManager.getVersion());
         updateDialog.setHeaderText("Updating");
         updateDialog.show();
 
         if (!downloadAndRunLatestRelease()) {
             updateDialog.close();
 
             Dialog errorDialog = new Dialog();
-            errorDialog.setTitle("Explv's OSBot Manager");
+            errorDialog.setTitle("Explv's OSBot Manager " + ExplvOSBotManager.getVersion());
             errorDialog.setHeaderText("Error!");
             errorDialog.setContentText("Failed to download latest version");
             errorDialog.getDialogPane().getButtonTypes().add(ButtonType.CLOSE);