fix: get_smartapp_list smartapp.name set as optional

Author: Leonid Gorbunov

pybotx/client/smartapps_api/smartapps_list.py

@@ -22,7 +22,7 @@ class BotXAPISmartAppEntity(VerifiedPayloadBaseModel):
     app_id: str
     enabled: bool
     id: UUID
-    name: str
+    name: Optional[str] = None
     avatar: Optional[str] = None
     avatar_preview: Optional[str] = None
 

pybotx/models/smartapps.py

@@ -19,6 +19,6 @@ class SmartApp:
     app_id: str
     enabled: bool
     id: UUID
-    name: str
+    name: Optional[str] = None
     avatar: Optional[str] = None
     avatar_preview: Optional[str] = None

tests/client/smartapps_api/test_smartapps_list.py

@@ -69,3 +69,58 @@ async def test__smartapps_list__succeed(
         ),
     ]
     assert version == 1
+
+
+async def test__smartapps_list__succeed_without_name(
+    respx_mock: MockRouter,
+    host: str,
+    bot_id: UUID,
+    bot_account: BotAccountWithSecret,
+) -> None:
+    # - Arrange -
+    endpoint = respx_mock.get(
+        f"https://{host}/api/v3/botx/smartapps/list",
+        headers={"Authorization": "Bearer token"},
+    ).mock(
+        return_value=httpx.Response(
+            HTTPStatus.OK,
+            json={
+                "result": {
+                    "phonebook_version": 1,
+                    "smartapps": [
+                        {
+                            "app_id": "amazing_smartapp",
+                            "avatar": "https://cts.example.com/uploads/profile_avatar/foo",
+                            "avatar_preview": "https://cts.example.com/uploads/profile_avatar/bar",
+                            "enabled": True,
+                            "id": "dc4acaf2-310f-4b0f-aec7-253b9def42ac",
+                            "name": None,
+                        },
+                    ],
+                },
+                "status": "ok",
+            },
+        ),
+    )
+
+    built_bot = Bot(collectors=[HandlerCollector()], bot_accounts=[bot_account])
+
+    # - Act -
+    async with lifespan_wrapper(built_bot) as bot:
+        smartapps_list, version = await bot.get_smartapps_list(
+            bot_id=bot_id,
+        )
+
+    # - Assert -
+    assert endpoint.called
+    assert smartapps_list == [
+        SmartApp(
+            app_id="amazing_smartapp",
+            avatar="https://cts.example.com/uploads/profile_avatar/foo",
+            avatar_preview="https://cts.example.com/uploads/profile_avatar/bar",
+            enabled=True,
+            id=UUID("dc4acaf2-310f-4b0f-aec7-253b9def42ac"),
+            name=None,
+        ),
+    ]
+    assert version == 1