Merge pull request #59 from ExtendRealityLtd/refactor/split-more-inspector-methods

fix(MemberChange): refactor inspector logic to be more composable

Author: extendreality

Sources/FodyRunner.UnityIntegration/InspectorEditor.cs

@@ -282,30 +282,50 @@ protected virtual void ApplyChangeHandlersToProperty(Object targetObject, Serial
         protected virtual void ProcessObjectProperties(SerializedProperty property)
         {
             string undoRedoWarningPropertyPath = UndoRedoWarningPropertyPath;
-
             do
             {
-                string propertyPath = property.propertyPath;
-                Object targetObject = property.serializedObject.targetObject;
+                ProcessObjectProperty(property, undoRedoWarningPropertyPath);
+            }
+            while (property.NextVisible(false));
+        }
 
-                using (EditorGUI.ChangeCheckScope changeCheckScope = new EditorGUI.ChangeCheckScope())
-                using (new EditorGUI.DisabledGroupScope(propertyPath == ScriptProperty))
-                {
-                    bool showUndoRedoWarning = CanShowUndoRedoWarning(propertyPath, undoRedoWarningPropertyPath);
-                    BeginDrawWarningMessage(showUndoRedoWarning);
-                    DrawProperty(property);
-                    EndDrawWarningMessage(showUndoRedoWarning);
+        /// <summary>
+        /// Processes the individual property.
+        /// </summary>
+        /// <param name="property">The property to process.</param>
+        /// <param name="undoRedoWarningPropertyPath">The path for the property for the undo/redo warning.</param>
+        protected virtual void ProcessObjectProperty(SerializedProperty property, string undoRedoWarningPropertyPath)
+        {
+            string propertyPath = property.propertyPath;
+            Object targetObject = property.serializedObject.targetObject;
 
-                    // No change has been done, nothing to do.
-                    if (!changeCheckScope.changed)
-                    {
-                        continue;
-                    }
+            using (EditorGUI.ChangeCheckScope changeCheckScope = new EditorGUI.ChangeCheckScope())
+            using (new EditorGUI.DisabledGroupScope(propertyPath == ScriptProperty))
+            {
+                DrawPropertyWithWarningMessage(property, propertyPath, undoRedoWarningPropertyPath);
 
-                    TryApplyChangeHandlersToProperty(targetObject, property);
+                // No change has been done, nothing to do.
+                if (!changeCheckScope.changed)
+                {
+                    return;
                 }
+
+                TryApplyChangeHandlersToProperty(targetObject, property);
             }
-            while (property.NextVisible(false));
+        }
+
+        /// <summary>
+        /// Draws the given property wrapped with an undo/redo warning message.
+        /// </summary>
+        /// <param name="property">The property to draw.</param>
+        /// <param name="propertyPath">The path to the property.</param>
+        /// <param name="undoRedoWarningPropertyPath">The path for the property for the undo/redo warning.</param>
+        protected virtual void DrawPropertyWithWarningMessage(SerializedProperty property, string propertyPath, string undoRedoWarningPropertyPath)
+        {
+            bool showUndoRedoWarning = CanShowUndoRedoWarning(propertyPath, undoRedoWarningPropertyPath);
+            BeginDrawWarningMessage(showUndoRedoWarning);
+            DrawProperty(property);
+            EndDrawWarningMessage(showUndoRedoWarning);
         }
 
         /// <summary>