Build fails under debian

[duduke]

Trying to build under debian (with zstd, libzstd-dev installed) fails with the following:

CMake Error at CMakeLists.txt:32 (find_package):
  By not providing "Findzstd.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "zstd", but
  CMake did not find one.

  Could not find a package configuration file provided by "zstd" with any of
  the following names:

    zstdConfig.cmake
    zstd-config.cmake

  Add the installation prefix of "zstd" to CMAKE_PREFIX_PATH or set
  "zstd_DIR" to a directory containing one of the above files.  If "zstd"
  provides a separate development package or SDK, be sure it has been
  installed.

[misuzu]

I have similar issue when building using nix:

building '/nix/store/70sycrygs9y835qnb0asj43h876s9907-ZArchive-0.1.1.drv'...
unpacking sources
unpacking source archive /nix/store/qpmq7ma7nsi86n3dkq7fxhs99nfclcii-source
source root is source
patching sources
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/share/doc/ZArchive -DCMAKE_INSTALL_INFODIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/58pwclg9yr437h0pfgrnbd0jis8fqasd-gcc-wrapper-11.2.0/bin/strip -DCMAKE_RANLIB=/nix/store/m2vh2ny7bqpwij1gpmvl5gxj7y4dgr4f-binutils-2.38/bin/ranlib -DCMAKE_AR=/nix/store/m2vh2ny7bqpwij1gpmvl5gxj7y4dgr4f-binutils-2.38/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/n0fkjpnsca8ax9mf1sbjhksa6qxmy2m0-ZArchive-0.1.1
-- The C compiler identification is GNU 11.2.0
-- The CXX compiler identification is GNU 11.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/58pwclg9yr437h0pfgrnbd0jis8fqasd-gcc-wrapper-11.2.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/58pwclg9yr437h0pfgrnbd0jis8fqasd-gcc-wrapper-11.2.0/bin/g++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
CMake Error at CMakeLists.txt:18 (add_library):
  Target "zarchive" links to target "zstd::libzstd_static" but the target was
  not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


CMake Error at CMakeLists.txt:36 (add_executable):
  Target "zarchiveTool" links to target "zstd::libzstd_static" but the target
  was not found.  Perhaps a find_package() call is missing for an IMPORTED
  target, or an ALIAS target is missing?


-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025


CMake Generate step failed.  Build files cannot be regenerated correctly.
error: builder for '/nix/store/70sycrygs9y835qnb0asj43h876s9907-ZArchive-0.1.1.drv' failed with exit code 1;

Am I using the wrong version of zstd library? Here is the nix derivation:

{ stdenv, lib, fetchFromGitHub, cmake, zstd }:

stdenv.mkDerivation rec {
  pname = "ZArchive";
  version = "0.1.1";

  src = fetchFromGitHub {
    owner = "Exzap";
    repo = pname;
    rev = "v${version}";
    sha256 = "sha256-qsUn2aOeMeGJKmxJ2Hf9jDbfwvS3REUes1eNkQFq62I=";
  };

  nativeBuildInputs = [ cmake ];

  buildInputs = [ zstd ];

  meta = with lib; {
    description = "Library for creating and reading zstd-compressed file archives (.zar)";
    homepage = "https://github.com/Exzap/ZArchive";
    maintainers = with maintainers; [ misuzu ];
    platforms = platforms.unix;
    license = licenses.mit;
  };
}

[jaimeMF]

I created an RPM for openSUSE ( https://build.opensuse.org/package/show/home:jaimeMF/zarchive ) and I had to modify the RPM of zstd ( https://build.opensuse.org/package/show/home:jaimeMF:branches:Archiving/zstd ) to use cmake for building and installing. With cmake the files needed for building ZArchive are correctly installed.

@misuzu I had to explicitly add the dependency on libzstd-devel-static, ¿is the static library available on nix?

[misuzu]

@misuzu I had to explicitly add the dependency on libzstd-devel-static, ¿is the static library available on nix?

Makes sense, thanks! This nix derivation worked for me:

{ stdenv, lib, fetchFromGitHub, fetchpatch, cmake, zstd }:

stdenv.mkDerivation rec {
  pname = "zarchive";
  version = "0.1.1";

  src = fetchFromGitHub {
    owner = "Exzap";
    repo = "ZArchive";
    rev = "v${version}";
    sha256 = "sha256-qsUn2aOeMeGJKmxJ2Hf9jDbfwvS3REUes1eNkQFq62I=";
  };

  patches = [
    (fetchpatch {
      url = "https://github.com/Exzap/ZArchive/commit/bbe67b9b21e5f6f41fcbbadee4fada53bcadebf1.patch";
      sha256 = "sha256-6KzxvtaaCdCULW6ZMR6wkrhprgm4AuNswKUJ9phjqvc=";
    })
    (fetchpatch {
      url = "https://github.com/Exzap/ZArchive/commit/d1bcb5ac9f31a4a94db92a4e3f45ba58dc7cc1db.patch";
      sha256 = "sha256-hoO3Yap6s7YdjbfnXUFKFE/A1IGHLHo9yO6lU8ZkZ+g=";
    })
  ];

  nativeBuildInputs = [ cmake ];

  buildInputs = [
    (zstd.override { static = true; })
  ];

  meta = with lib; {
    description = "Library for creating and reading zstd-compressed file archives (.zar)";
    homepage = "https://github.com/Exzap/ZArchive";
    maintainers = with maintainers; [ misuzu ];
    platforms = platforms.unix;
    license = licenses.mit;
  };
}

While it works for Linux, it fails to build on macOS, but I guess that's an issue with the clang version:

building '/nix/store/6d3pb1w3d0hnpf7w8xs03sb9a8q8frgw-zarchive-0.1.1.drv'...
unpacking sources
unpacking source archive /nix/store/qpmq7ma7nsi86n3dkq7fxhs99nfclcii-source
source root is source
patching sources
applying patch /nix/store/2aidh733i8c1sblkzyi3m2lhzgbshqnn-bbe67b9b21e5f6f41fcbbadee4fada53bcadebf1.patch
patching file CMakeLists.txt
applying patch /nix/store/jl9yz6kh5fl0z585fnrldjp4mpzx8x16-d1bcb5ac9f31a4a94db92a4e3f45ba58dc7cc1db.patch
patching file CMakeLists.txt
updateAutotoolsGnuConfigScriptsPhase
configuring
fixing cmake files...
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_SKIP_BUILD_RPATH=ON -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/share/doc/ZArchive -DCMAKE_INSTALL_INFODIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/nwfcj1p4l74krm4n6szrb0c534p4ai2s-clang-wrapper-11.1.0/bin/strip -DCMAKE_RANLIB=/nix/store/baplgma04mfrvivyg7i25py9wz9nr446-cctools-binutils-darwin-949.0.1/bin/ranlib -DCMAKE_AR=/nix/store/baplgma04mfrvivyg7i25py9wz9nr446-cctools-binutils-darwin-949.0.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/8kaqpwymfmixxy7l8h202hqmzm445hwh-zarchive-0.1.1
-- The C compiler identification is Clang 11.1.0
-- The CXX compiler identification is Clang 11.1.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/nwfcj1p4l74krm4n6szrb0c534p4ai2s-clang-wrapper-11.1.0/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /nix/store/nwfcj1p4l74krm4n6szrb0c534p4ai2s-clang-wrapper-11.1.0/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025


-- Build files have been written to: /tmp/nix-build-zarchive-0.1.1.drv-0/source/build
cmake: enabled parallel building
building
build flags: -j10 -l10 SHELL=/nix/store/cmcl1jichs33ynwv5apzs8r8ndx2w2pi-bash-5.1-p16/bin/bash
[ 50%] Building CXX object CMakeFiles/zarchive.dir/src/zarchivereader.cpp.o
[ 50%] Building CXX object CMakeFiles/zarchive.dir/src/zarchivewriter.cpp.o
[ 50%] Building C object CMakeFiles/zarchive.dir/src/sha_256.c.o
/tmp/nix-build-zarchive-0.1.1.drv-0/source/src/zarchivereader.cpp:238:23: error: no matching function for call to 'min'
                uint32_t stepSize = std::min(remainingBytes, _ZARCHIVE::COMPRESSED_BLOCK_SIZE - blockOffset);
                                    ^~~~~~~~
/nix/store/1r3mrri4afdhshaibaamb3rafvy4ngv9-libcxx-11.1.0-dev/include/c++/v1/algorithm:2560:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long long' vs. 'unsigned long')
min(const _Tp& __a, const _Tp& __b)
^
/nix/store/1r3mrri4afdhshaibaamb3rafvy4ngv9-libcxx-11.1.0-dev/include/c++/v1/algorithm:2571:1: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'unsigned long long'
min(initializer_list<_Tp> __t, _Compare __comp)
^
/nix/store/1r3mrri4afdhshaibaamb3rafvy4ngv9-libcxx-11.1.0-dev/include/c++/v1/algorithm:2580:1: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
min(initializer_list<_Tp> __t)
^
/nix/store/1r3mrri4afdhshaibaamb3rafvy4ngv9-libcxx-11.1.0-dev/include/c++/v1/algorithm:2551:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
min(const _Tp& __a, const _Tp& __b, _Compare __comp)
^
1 error generated.
make[2]: *** [CMakeFiles/zarchive.dir/build.make:90: CMakeFiles/zarchive.dir/src/zarchivereader.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/zarchive.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
error: builder for '/nix/store/6d3pb1w3d0hnpf7w8xs03sb9a8q8frgw-zarchive-0.1.1.drv' failed with exit code 2;

[misuzu]

it fails to build on macOS

#5 fixes the macOS issue for me. Final nix derivation now looks like this:

{ stdenv, lib, fetchFromGitHub, fetchpatch, cmake, zstd }:

stdenv.mkDerivation rec {
  pname = "zarchive";
  version = "0.1.1";

  src = fetchFromGitHub {
    owner = "Exzap";
    repo = "ZArchive";
    rev = "v${version}";
    sha256 = "sha256-qsUn2aOeMeGJKmxJ2Hf9jDbfwvS3REUes1eNkQFq62I=";
  };

  patches = [
    (fetchpatch {
      url = "https://github.com/Exzap/ZArchive/commit/bbe67b9b21e5f6f41fcbbadee4fada53bcadebf1.patch";
      sha256 = "sha256-6KzxvtaaCdCULW6ZMR6wkrhprgm4AuNswKUJ9phjqvc=";
    })
    (fetchpatch {
      url = "https://github.com/Exzap/ZArchive/commit/d1bcb5ac9f31a4a94db92a4e3f45ba58dc7cc1db.patch";
      sha256 = "sha256-hoO3Yap6s7YdjbfnXUFKFE/A1IGHLHo9yO6lU8ZkZ+g=";
    })
    (fetchpatch {
      url = "https://github.com/Exzap/ZArchive/commit/9a1c6723fe5449de6e2cc7da4a24e76b172bbda9.patch";
      sha256 = "sha256-k83cBEMhfjcpymFYX8R7NB96th5VjwEFcTnG4O9w4pQ=";
    })
  ];

  nativeBuildInputs = [ cmake ];

  buildInputs = [
    (zstd.override { static = true; })
  ];

  meta = with lib; {
    description = "Library for creating and reading zstd-compressed file archives (.zar)";
    homepage = "https://github.com/Exzap/ZArchive";
    maintainers = with maintainers; [ misuzu ];
    platforms = platforms.unix;
    license = licenses.mit;
  };
}

[duduke]

@misuzu what changes do I need to make to the code to build it under debian?
Thanks.

[misuzu]

@misuzu what changes do I need to make to the code to build it under debian? Thanks.

I haven't used Debian for years, but you could try replacing zstd::libzstd_static to zstd::libzstd_shared in CMakeLists.txt, maybe that helps.

[Dark3clipse]

It builds for me with ubuntu 22.04 using this:

cmake_minimum_required (VERSION 3.15)

set(CMAKE_CXX_STANDARD 20)

cmake_policy(SET CMP0091 NEW) # for MSVC_RUNTIME_LIBRARY

set(VCPKG_TARGET_TRIPLET "x64-windows-static" CACHE STRING "VCPKG Target Triplet to use")

project ("ZArchive")

set(SOURCE_FILES_LIB
src/zarchivewriter.cpp
src/zarchivereader.cpp
src/sha_256.c
)

# build static library
add_library (zarchive STATIC ${SOURCE_FILES_LIB})
set_property(TARGET zarchive PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")

target_include_directories(zarchive
    PUBLIC
        $<INSTALL_INTERFACE:include>
        $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
)


include_directories(PRIVATE
${CMAKE_CURRENT_SOURCE_DIR}/include
)

find_path(/usr/include/ zstd.h)
TARGET_LINK_LIBRARIES(zarchive PRIVATE /usr/lib/x86_64-linux-gnu/libzstd.so)

# standalone executable
add_executable (zarchiveTool src/main.cpp)
set_property(TARGET zarchiveTool PROPERTY MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
set_target_properties(zarchiveTool PROPERTIES OUTPUT_NAME "zarchive")
target_link_libraries(zarchiveTool PRIVATE zarchive)

# install
include(GNUInstallDirs)

install(DIRECTORY ${CMAKE_SOURCE_DIR}/include/zarchive/ DESTINATION "include/zarchive" FILES_MATCHING PATTERN "zarchive*.h")
INSTALL(TARGETS zarchive LIBRARY)
INSTALL(TARGETS zarchiveTool)

[Tachi107]

The solution is likely to include a Findzstd.cmake module that uses pkg-config to locate the library.

You can use the following code under the terms of the ISC license:

# SPDX-FileCopyrightText: 2022 Andrea Pappacoda <andrea at pappacoda dot it>
# SPDX-License-Identifier: ISC

find_package(PkgConfig)

if (PKG_CONFIG_FOUND)
	pkg_search_module(libzstd IMPORTED_TARGET GLOBAL libzstd)
	if (libzstd_FOUND)
		add_library(zstd::zstd ALIAS PkgConfig::libzstd)

		# pkg_search_module() only creates an imported target for the shared one
		if (NOT TARGET zstd::libzstd_static)
			add_library(zstd::libzstd_static INTERFACE IMPORTED GLOBAL)
			target_compile_options(zstd::libzstd_static INTERFACE
				${libzstd_STATIC_CFLAGS}
				${libzstd_STATIC_CFLAGS_OTHER}
			)
			target_include_directories(zstd::libzstd_static INTERFACE
				${libzstd_STATIC_INCLUDE_DIRS}
			)
			target_link_directories(zstd::libzstd_static INTERFACE
				${libzstd_STATIC_LIBRARY_DIRS}
			)
			target_link_libraries(zstd::libzstd_static INTERFACE
				${libzstd_STATIC_LIBRARIES}
				${libzstd_STATIC_LINK_LIBRARIES}
			)
			target_link_options(zstd::libzstd_static INTERFACE
				${libzstd_STATIC_LDFLAGS}
				${libzstd_STATIC_LDFLAGS_OTHER}
			)
		endif()
	endif()
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(zstd
	REQUIRED_VARS
		libzstd_LINK_LIBRARIES
		libzstd_FOUND
	VERSION_VAR libzstd_VERSION
)

[Tachi107]

Should be fixed with 116265a