Skip to content

Commit ef6b14f

Browse files
committed
Rename variables
THE PVP MODULES SHOULD WORK BUT THEY MIGHT BE MALFUNCTIONING AS THEY WEREN'T TESTED AT ALL!
1 parent 2f8e85c commit ef6b14f

File tree

2 files changed

+17
-17
lines changed

2 files changed

+17
-17
lines changed

DataAPI/PvP.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,10 @@ function PvP:GetConquestProgressInfo()
100100
INFO.Rated.Conquest.displayType = nil
101101

102102
if DATA.SeasonState == ARENA_SEASON_STATE.Active or DATA.SeasonState == ARENA_SEASON_STATE.OffSeason then
103-
local currencyInfo = C_CurrencyInfo.GetCurrencyInfo(Constants.CurrencyConsts.CONQUEST_CURRENCY_ID)
103+
local currency = C_CurrencyInfo.GetCurrencyInfo(Constants.CurrencyConsts.CONQUEST_CURRENCY_ID)
104104

105-
local currentValue = currencyInfo.totalEarned
106-
local maxValue = currencyInfo.maxQuantity
105+
local currentValue = currency.totalEarned
106+
local maxValue = currency.maxQuantity
107107
local isCapped = currentValue >= maxValue
108108

109109
local weeklyProgress = C_WeeklyRewards.GetConquestWeeklyProgress()

Display/PvP.lua

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -25,20 +25,20 @@ Display:RegisterHookScript(LFDMicroButton, "OnEnter", function(self)
2525
:ToLine()
2626

2727
if IsPlayerAtEffectiveMaxLevel() then
28-
local conquestInfo = PvP:GetConquestProgressInfo()
28+
local conquest = PvP:GetConquestProgressInfo()
2929

30-
if conquestInfo then
30+
if conquest then
3131
Display:SetLine(L["Conquest"])
32-
if not conquestInfo.isCapped then
33-
Display:SetFormattedLine(STANDING_FORMAT, conquestInfo.currentValue, conquestInfo.maxValue)
34-
if conquestInfo.displayType == Enum.ConquestProgressBarDisplayType.Seasonal then
32+
if not conquest.isCapped then
33+
Display:SetFormattedLine(STANDING_FORMAT, conquest.currentValue, conquest.maxValue)
34+
if conquest.displayType == Enum.ConquestProgressBarDisplayType.Seasonal then
3535
Display:SetYellowColor()
3636
else
3737
Display:SetBlueColor()
3838
end
3939
else
4040
Display
41-
:SetFormattedLine(conquestInfo.currentValue)
41+
:SetFormattedLine(conquest.currentValue)
4242
:SetGrayColor()
4343
end
4444
Display:ToLine()
@@ -47,27 +47,27 @@ Display:RegisterHookScript(LFDMicroButton, "OnEnter", function(self)
4747
:SetDoubleLine(L["Rated PvP"], L["Weekly Stats"])
4848
:ToHeader()
4949

50-
for info in PvP:IterableBracketInfo() do
51-
if info.rating > 0 then
50+
for bracket in PvP:IterableBracketInfo() do
51+
if bracket.rating > 0 then
5252
Display
53-
:SetFormattedLine(RATED_PVP_LABEL_FORMAT, info.name, info.rating)
54-
:SetFormattedLine(RATED_PVP_WEEKLY_STATUS_FORMAT, info.weeklyPlayed, info.weeklyWon, info.weeklyLost)
53+
:SetFormattedLine(RATED_PVP_LABEL_FORMAT, bracket.name, bracket.rating)
54+
:SetFormattedLine(RATED_PVP_WEEKLY_STATUS_FORMAT, bracket.weeklyPlayed, bracket.weeklyWon, bracket.weeklyLost)
5555
:SetHighlight()
5656
else
5757
Display
58-
:SetLine(info.name)
58+
:SetLine(bracket.name)
5959
:SetGrayColor()
6060
:SetLine(0)
6161
:SetGrayColor()
6262
end
6363
Display:ToLine()
6464

65-
if info.tierName and IsShiftKeyDown() then
65+
if bracket.tierName and IsShiftKeyDown() then
6666
Display
67-
:SetFormattedLine(RATED_PVP_NEXT_RANK, info.tierName, info.nextTierName)
67+
:SetFormattedLine(RATED_PVP_NEXT_RANK, bracket.tierName, bracket.nextTierName)
6868
:ToLine()
6969

70-
Display:AddIcon(info.tierIcon)
70+
Display:AddIcon(bracket.tierIcon)
7171
end
7272
end
7373

0 commit comments

Comments
 (0)