Skip to content

Commit 9ee0d7a

Browse files
Merge pull request #137 from EyeSeeTea/fix/use-docker-compose-v2
[feature] Support docker compose as plugin
2 parents c64d827 + 228611e commit 9ee0d7a

File tree

6 files changed

+13
-14
lines changed

6 files changed

+13
-14
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
On Ubuntu 22.04:
1010

1111
```
12-
$ sudo apt install docker.io docker-compose python3 python3-setuptools
12+
$ sudo apt install docker.io docker-compose-v2 python3 python3-setuptools
1313
```
1414

1515
On Windows 10:

requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
Flask==2.0.3
1+
Flask==3.1.0
22
python-dotenv
33
Flask_Cors==6.0.0
4-
Werkzeug==2.3.7
5-
requests==2.31.0
4+
requests==2.32.3
65
PyYAML
6+
setuptools

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
setuptools.setup(
66
name="d2_docker",
7-
version="1.15.0.b1",
7+
version="1.15.0.b2",
88
description="Dockers for DHIS2 instances",
99
long_description=open("README.md", encoding="utf-8").read(),
1010
keywords=["python"],

src/d2_docker/commands/version.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import pkg_resources # part of setuptools
1+
from importlib.metadata import distribution
22
import re
33
from d2_docker import utils
44

@@ -11,7 +11,7 @@ def setup(_parser):
1111

1212
def run(_args):
1313
utils.run(["docker", "-v"])
14-
utils.run(["docker-compose", "-v"])
14+
utils.run(["docker", "compose", "version"])
1515
d2_docker = get_d2_docker_version()
1616
if d2_docker:
1717
print("d2-docker version {}".format(d2_docker))
@@ -32,11 +32,11 @@ def get_field(command, field_index):
3232

3333
def get_versions():
3434
docker = get_field(["docker", "-v"], 2)
35-
docker_compose = get_field(["docker-compose", "-v"], 3)
35+
docker_compose = get_field(["docker", "compose", "version"], 3)
3636
d2_docker = get_d2_docker_version()
3737
return dict({"docker": docker, "docker-compose": docker_compose, "d2-docker": d2_docker})
3838

3939

4040
def get_d2_docker_version():
41-
resources = pkg_resources.require("d2-docker")
42-
return resources[0].version if resources else None
41+
dist = distribution("d2-docker")
42+
return dist.version

src/d2_docker/docker-compose.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
version: "3"
21
services:
32
core:
43
image: "${DHIS2_CORE_IMAGE}"

src/d2_docker/utils.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import time
1111
import yaml
1212
import urllib.request
13-
from distutils import dir_util
13+
from setuptools._distutils import dir_util
1414
from pathlib import Path
1515
from typing import Optional
1616

@@ -308,7 +308,7 @@ def process_yaml(data):
308308

309309
temp_compose = build_docker_compose(process_yaml)
310310

311-
return run(["docker-compose", "-f", temp_compose.name, "-p", project_name, *args], env=env, **kwargs)
311+
return run(["docker", "compose", "-f", temp_compose.name, "-p", project_name, *args], env=env, **kwargs)
312312

313313

314314
def build_docker_compose(process_yaml):
@@ -553,7 +553,7 @@ def add_core_image_arg(parser):
553553

554554
@contextlib.contextmanager
555555
def running_containers(image_name, *up_args, **run_docker_compose_kwargs):
556-
"""Start docker-compose services for an image in a context manager and stop it afterwards."""
556+
"""Start docker compose services for an image in a context manager and stop it afterwards."""
557557
try:
558558
run_docker_compose(["up", "-d", *up_args], image_name, **run_docker_compose_kwargs)
559559
status = get_image_status(image_name)

0 commit comments

Comments
 (0)