Merge pull request #144 from edgeware/fix-crop

tobbee · web-flow · commit a77c238df1d2 · 2022-05-12T10:58:14.000+02:00
fix mp4ff-crop: better bad cli options handling
diff --git a/cmd/mp4ff-crop/main.go b/cmd/mp4ff-crop/main.go
@@ -45,7 +45,6 @@ func parseOptions() {
 }
 
 func main() {
-
 	parseOptions()
 
 	if opts.version {
@@ -54,12 +53,14 @@ func main() {
 	}
 
 	if opts.durationMS <= 0 {
+		fmt.Printf("error: duration must be larger than 0\n\n")
 		flag.Usage()
 		os.Exit(1)
 	}
 
 	var inFilePath = flag.Arg(0)
 	if inFilePath == "" {
+		fmt.Printf("error: no infile path specified\n\n")
 		flag.Usage()
 		os.Exit(1)
 	}

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,6 @@ func parseOptions() {`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`func main() {`
`48`		`-`
`49`	`48`	`parseOptions()`
`50`	`49`
`51`	`50`	`if opts.version {`
`@@ -54,12 +53,14 @@ func main() {`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`if opts.durationMS <= 0 {`
	`56`	`+ fmt.Printf("error: duration must be larger than 0\n\n")`
`57`	`57`	`flag.Usage()`
`58`	`58`	`os.Exit(1)`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`var inFilePath = flag.Arg(0)`
`62`	`62`	`if inFilePath == "" {`
	`63`	`+ fmt.Printf("error: no infile path specified\n\n")`
`63`	`64`	`flag.Usage()`
`64`	`65`	`os.Exit(1)`
`65`	`66`	`}`