Add authorization for delete endpoint in SDK (#145)

* fix: add authorization for delete endpoint in SDK (#12)

* fix: don't use Authorization header if no auth key was provided (#12)

---------

Co-authored-by: Frittman Detre <detre.frittman@scolia.hu>

Author: DETERr

packages/sdk/spec/WHIPClient.spec.ts

@@ -470,7 +470,7 @@ describe('WHIP Client', () => {
     });
 
     it('Does not close peer connection when connection state transitions to disconnected', async () => {
-        when(whipProtocol.delete(anyString()))
+        when(whipProtocol.delete(anyString(), undefined))
             .thenResolve(instance(response));
 
         when(rtcPeerConnection.connectionState)
@@ -484,7 +484,7 @@ describe('WHIP Client', () => {
     })
 
     it('Closes peer connection when connection state transitions to failed', async () => {
-        when(whipProtocol.delete(anyString()))
+        when(whipProtocol.delete(anyString(), undefined))
             .thenResolve(instance(response));
 
         when(rtcPeerConnection.connectionState)

packages/sdk/src/WHIPProtocol.ts

@@ -1,39 +1,60 @@
 export class WHIPProtocol {
 
     sendOffer(url: string, authKey: string | undefined, sdp: string): Promise<Response> {
+        const headers = {
+            "Content-Type": "application/sdp",
+        };
+
+        if (authKey) {
+            headers['Authorization'] = `Bearer ${authKey}`;
+        }
+
         return fetch(url, {
             method: "POST",
-            headers: {
-                "Content-Type": "application/sdp",
-                "Authorization": `Bearer ${authKey}`
-            },
+            headers,
             body: sdp
         });
     }
 
     getConfiguration(url: string, authKey: string | undefined): Promise<Response> {
+        const headers = {};
+
+        if (authKey) {
+            headers['Authorization'] = `Bearer ${authKey}`;
+        }
+
         return fetch(url, {
             method: "OPTIONS",
-            headers: {
-                "Authorization": `Bearer ${authKey}`,
-            }
+            headers
         });
     }
 
-    delete(url: string): Promise<Response> {
+    delete(url: string, authKey: string | undefined): Promise<Response> {
+        const headers = {};
+
+        if (authKey) {
+            headers['Authorization'] = `Bearer ${authKey}`;
+        }
+
         return fetch(url, {
-            method: "DELETE"
+            method: "DELETE",
+            headers
         });
     }
 
     updateIce(url: string, eTag: string, sdp: string, authKey: string | undefined): Promise<Response> {
+        const headers = {
+            "Content-Type": "application/trickle-ice-sdpfrag",
+            "ETag": eTag,
+        };
+
+        if (authKey) {
+            headers['Authorization'] = `Bearer ${authKey}`;
+        }
+
         return fetch(url, {
             method: "PATCH",
-            headers: {
-                "Content-Type": "application/trickle-ice-sdpfrag",
-                "ETag": eTag,
-                "Authorization": `Bearer ${authKey}`,
-            },
+            headers,
             body: sdp
         });
     }

packages/sdk/src/index.ts

@@ -384,7 +384,7 @@ export class WHIPClient extends EventEmitter {
  */
   async destroy(): Promise<void> {
     const resourceUrl = await this.getResourceUrl();
-    await this.whipProtocol.delete(resourceUrl).catch((e) => this.error("destroy()", e));
+    await this.whipProtocol.delete(resourceUrl, this.opts.authkey).catch((e) => this.error("destroy()", e));
 
     const senders = this.peer.getSenders();
     if (senders) {