Add missing foreign keys on player_events and friends_and_foes

Author: Brutus5000

migrations/V68__add_foreign_keys.sql

@@ -0,0 +1,36 @@
+-- Cleanup records with player_events referencing non-existing accounts
+DELETE player_events
+FROM player_events
+LEFT JOIN login on login.id = player_events.player_id
+WHERE login.id IS NULL;
+
+
+-- Add foreign key constraint for player_events -> login
+ALTER TABLE player_events MODIFY player_id MEDIUMINT UNSIGNED NOT NULL COMMENT 'The ID of the player that triggered this event.';
+
+ALTER TABLE player_events
+	ADD CONSTRAINT player_events_login_id_fk
+		FOREIGN KEY (player_id) REFERENCES login (id);
+
+
+
+-- Cleanup records with friends_and_foes referencing non-existing accounts
+DELETE friends_and_foes
+FROM friends_and_foes
+         LEFT JOIN login ON login.id = friends_and_foes.user_id
+WHERE login.id IS NULL;
+
+DELETE friends_and_foes
+FROM friends_and_foes
+         LEFT JOIN login ON login.id = friends_and_foes.subject_id
+WHERE login.id IS NULL;
+
+-- Add foreign key constraint for friends_and_foes -> login
+ALTER TABLE friends_and_foes
+    ADD CONSTRAINT friends_and_foes_user_login_id_fk
+        FOREIGN KEY (user_id) REFERENCES login (id);
+
+ALTER TABLE friends_and_foes
+    ADD CONSTRAINT friends_and_foes_subject_login_id_fk
+        FOREIGN KEY (subject_id) REFERENCES login (id);
+

test-data.sql

@@ -1,5 +1,6 @@
 -- DUMMY DATA ONLY, FOR USE IN UNIT TESTS
 
+DELETE FROM player_events;
 DELETE FROM reported_user;
 DELETE FROM moderation_report;
 DELETE FROM teamkills;
@@ -158,8 +159,8 @@ insert into game_stats (id, startTime, gameName, gameType, gameMod, `host`, mapI
 values (1, NOW(), 'Test game', '0', 6, 1, 1, 0);
 
 insert into friends_and_foes (user_id, subject_id, `status`)
-values(42, 56, 'FRIEND'),
-      (42, 57, 'FOE');
+values(1, 2, 'FRIEND'),
+      (1, 3, 'FOE');
 
 insert into `mod` (id, display_name, author)
 VALUES (1, 'test-mod', 'baz'),