Add lifecycle hook to remove memberships from players

Author: Sheikah45

src/inttest/java/com/faforever/api/data/ClanElideTest.java

@@ -167,14 +167,9 @@ private String generateTransferLeadershipContent(int clanId, int newLeaderId) {
 
   @Test
   public void canDeleteClanAsLeader() throws Exception {
-    Clan clan = clanRepository.findOneByName("Alpha Clan")
+    clanRepository.findOneByName("Alpha Clan")
       .orElseThrow(() -> new IllegalStateException("Alpha Clan could not be found"));
 
-    List<Player> clanMember = new ArrayList<>();
-    clan.getMemberships().stream()
-      .map(ClanMembership::getPlayer)
-      .forEach(clanMember::add);
-
     mockMvc.perform(
         delete("/data/clan/1")
           .with(getOAuthTokenForUserId(USERID_CLAN_LEADER)))

src/main/java/com/faforever/api/data/domain/Clan.java

@@ -2,17 +2,16 @@
 
 import com.faforever.api.data.checks.IsEntityOwner;
 import com.faforever.api.data.checks.Prefab;
+import com.faforever.api.data.hook.ClanHook;
 import com.faforever.api.data.listeners.ClanChangeListener;
 import com.faforever.api.data.listeners.ClanEnricherListener;
 import com.faforever.api.data.validation.IsLeaderInClan;
 import com.yahoo.elide.annotation.ComputedAttribute;
 import com.yahoo.elide.annotation.CreatePermission;
 import com.yahoo.elide.annotation.DeletePermission;
 import com.yahoo.elide.annotation.Include;
+import com.yahoo.elide.annotation.LifeCycleHookBinding;
 import com.yahoo.elide.annotation.UpdatePermission;
-import lombok.Setter;
-import org.hibernate.annotations.BatchSize;
-
 import jakarta.persistence.CascadeType;
 import jakarta.persistence.Column;
 import jakarta.persistence.Entity;
@@ -26,6 +25,9 @@
 import jakarta.validation.constraints.NotEmpty;
 import jakarta.validation.constraints.NotNull;
 import jakarta.validation.constraints.Size;
+import lombok.Setter;
+import org.hibernate.annotations.BatchSize;
+
 import java.util.Set;
 
 @Entity
@@ -36,6 +38,7 @@
 @Setter
 @IsLeaderInClan
 @EntityListeners({ClanEnricherListener.class, ClanChangeListener.class})
+@LifeCycleHookBinding(operation = LifeCycleHookBinding.Operation.DELETE, phase = LifeCycleHookBinding.TransactionPhase.PREFLUSH, hook = ClanHook.class)
 public class Clan extends AbstractEntity<Clan> implements OwnableEntity {
 
   public static final String TYPE_NAME = "clan";

src/main/java/com/faforever/api/data/hook/ClanHook.java

@@ -0,0 +1,23 @@
+package com.faforever.api.data.hook;
+
+import com.faforever.api.data.domain.Clan;
+import com.faforever.api.data.domain.ClanMembership;
+import com.yahoo.elide.annotation.LifeCycleHookBinding.Operation;
+import com.yahoo.elide.annotation.LifeCycleHookBinding.TransactionPhase;
+import com.yahoo.elide.core.lifecycle.LifeCycleHook;
+import com.yahoo.elide.core.security.ChangeSpec;
+import com.yahoo.elide.core.security.RequestScope;
+import org.springframework.stereotype.Component;
+
+import java.util.Optional;
+
+@Component
+public class ClanHook implements LifeCycleHook<Clan> {
+
+  @Override
+  public void execute(Operation operation, TransactionPhase phase, Clan clan, RequestScope requestScope, Optional<ChangeSpec> changes) {
+    if (operation == Operation.DELETE) {
+      clan.getMemberships().stream().map(ClanMembership::getPlayer).forEach(player -> player.setClanMembership(null));
+    }
+  }
+}