Skip to content

Commit ea65fcb

Browse files
authored
Make db-version and db-type required for maven-verify workflow (#41)
This is backward incompatible, because dependent workflows relying on optionality will break.
1 parent 79a71ac commit ea65fcb

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/maven-verify.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ on:
2828
type: number
2929
db-type:
3030
description: 'type of database: postgresql or mongodb'
31-
default: ''
32-
required: false
31+
required: true
3332
type: string
3433
db-name:
3534
description: 'name of database to be created'
@@ -49,8 +48,7 @@ on:
4948
required: false
5049
type: number
5150
db-version:
52-
default: 8
53-
required: false
51+
required: true
5452
type: number
5553

5654
jobs:

.github/workflows/test-maven-verify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ jobs:
4848
db-username: ${{ matrix.db-username || '' }}
4949
db-password: ${{ matrix.db-password || '' }}
5050
db-port: ${{ matrix.db-port || 0 }}
51-
db-version: ${{ matrix.db-version || 0 }}
51+
db-version: ${{ matrix.db-version }}

0 commit comments

Comments
 (0)