Resolve minor reviewer feedback

Author: ndaelman-hu

src/nomad_simulations/schema_packages/physical_property.py

@@ -32,15 +32,6 @@ class PhysicalProperty(PlotSection):
         """,
     )
 
-    source = Quantity(
-        type=MEnum('simulation', 'measurement', 'analysis'),
-        default='simulation',
-        description="""
-        Source of the physical property. This quantity is related with the `Activity` performed to obtain the physical
-        property. Example: an `ElectronicBandGap` can be obtained from a `'simulation'` or in a `'measurement'`.
-        """,
-    )  # ? useful
-
     type = Quantity(
         type=str,
         description="""

src/nomad_simulations/schema_packages/properties/energies.py

@@ -37,7 +37,7 @@ class TotalEnergy(BaseEnergy):
     """
 
     # ? add a generic contributions quantity to PhysicalProperty
-    contributions = SubSection(sub_section=SectionProxy('TotalEnergy'), repeats=True)
+    contributions = SubSection(sub_section=SectionProxy('BaseEnergy'), repeats=True)
 
 
 # ? Separate quantities for nuclear and electronic KEs?

tests/properties/test_band_structure.py

@@ -138,7 +138,7 @@ def test_order_eigenvalues(
         )
         order_result = electronic_eigenvalues.order_eigenvalues()
         if not order_result:
-            assert not result_validation  # Empty tuple means validation failed
+            assert result_validation == ()  # Empty tuple means validation failed
         else:
             sorted_value, sorted_occupation = order_result
             assert electronic_eigenvalues.m_cache['sorted_eigenvalues']