Remove superfluous defaults testing

Author: ndaelman-hu

tests/properties/test_band_gap.py

@@ -26,7 +26,6 @@ def test_default_quantities(self):
             electronic_band_gap.iri
             == 'http://fairmat-nfdi.eu/taxonomy/ElectronicBandGap'
         )
-        assert electronic_band_gap.name == 'ElectronicBandGap'
 
     @pytest.mark.parametrize(
         'momentum_transfer, type, result',

tests/properties/test_band_structure.py

@@ -33,7 +33,6 @@ def test_default_quantities(self, n_bands: Optional[int]):
             electronic_eigenvalues.iri
             == 'http://fairmat-nfdi.eu/taxonomy/ElectronicEigenvalues'
         )
-        assert electronic_eigenvalues.name == 'ElectronicEigenvalues'
 
     # @pytest.mark.parametrize(
     #     'occupation, result',

tests/properties/test_energies.py

@@ -24,4 +24,3 @@ def test_default_quantities(self, n_bands: Optional[int]):
         """
         fermi_surface = FermiSurface(n_bands=n_bands)
         assert fermi_surface.iri == 'http://fairmat-nfdi.eu/taxonomy/FermiSurface'
-        assert fermi_surface.name == 'FermiSurface'

tests/properties/test_fermi_surface.py

@@ -27,7 +27,6 @@ def test_default_quantities(self, n_orbitals: Optional[int], rank: Optional[list
         """
         hopping_matrix = HoppingMatrix(n_orbitals=n_orbitals)
         assert hopping_matrix.iri == 'http://fairmat-nfdi.eu/taxonomy/HoppingMatrix'
-        assert hopping_matrix.name == 'HoppingMatrix'
 
 
 class TestCrystalFieldSplitting:
@@ -51,4 +50,3 @@ def test_default_quantities(self, n_orbitals: Optional[int], rank: Optional[list
         assert (
             crystal_field.iri == 'http://fairmat-nfdi.eu/taxonomy/CrystalFieldSplitting'
         )
-        assert crystal_field.name == 'CrystalFieldSplitting'

tests/properties/test_forces.py

@@ -22,7 +22,6 @@ def test_default_quantities(self):
         """
         permittivity = Permittivity()
         assert permittivity.iri == 'http://fairmat-nfdi.eu/taxonomy/Permittivity'
-        assert permittivity.name == 'Permittivity'
 
     @pytest.mark.parametrize(
         'kmesh_grid, frequency, result',

tests/properties/test_hopping_matrix.py

@@ -34,7 +34,6 @@ def test_default_quantities(self):
             electronic_dos.iri
             == 'http://fairmat-nfdi.eu/taxonomy/ElectronicDensityOfStates'
         )
-        assert electronic_dos.name == 'ElectronicDensityOfStates'
 
     def test_resolve_energies_origin(self):
         """
@@ -209,24 +208,14 @@ def test_default_quantities(self):
         Test the default quantities assigned when creating an instance of the `AbsorptionSpectrum` class.
         """
         absorption_spectrum = AbsorptionSpectrum()
-        assert absorption_spectrum.iri is None  # Add iri when available
-        assert absorption_spectrum.name == 'AbsorptionSpectrum'
+        assert absorption_spectrum.iri == ''  # IRI is empty string by default
 
 
 class TestXASSpectrum:
     """
     Test the `XASSpectrum` class defined in `properties/spectral_profile.py`.
     """
 
-    # ! Include this initial `test_default_quantities` method when testing your PhysicalProperty classes
-    def test_default_quantities(self):
-        """
-        Test the default quantities assigned when creating an instance of the `XASSpectrum` class.
-        """
-        xas_spectrum = XASSpectrum()
-        assert xas_spectrum.iri is None  # Add iri when available
-        assert xas_spectrum.name == 'XASSpectrum'
-
     @pytest.mark.parametrize(
         'xanes_energies, exafs_energies, xas_values',
         [

tests/properties/test_permittivity.py

@@ -91,3 +91,11 @@ def test_plotting_and_contributions(self):
         # Both should be normalized
         assert main_property.m_cache.get('_is_normalized', False) is True
         assert contribution.m_cache.get('_is_normalized', False) is True
+
+    def test_name_setting_during_normalization(self):
+        """
+        Test that the name is set during normalization for PhysicalProperty.
+        """
+        property_obj = PhysicalProperty()
+        property_obj.normalize(EntryArchive(), logger)
+        assert property_obj.name == 'PhysicalProperty'

tests/properties/test_spectral_profile.py

@@ -33,3 +33,11 @@ def test_normalize(self, n_points: int, points: list, result: int):
         assert variable.get_n_points(logger) == result
         variable.normalize(EntryArchive(), logger)
         assert variable.n_points == result
+
+    def test_name_setting_during_normalization(self):
+        """
+        Test that the name is set during normalization for Variables.
+        """
+        variable = Variables()
+        variable.normalize(EntryArchive(), logger)
+        assert variable.name == 'Variables'