Add typing and fix mypy

Author: ndaelman-hu

src/nomad_simulations/schema_packages/physical_property.py

@@ -1,3 +1,5 @@
+from typing import TYPE_CHECKING
+
 from nomad import utils
 from nomad.datamodel.metainfo.basesections.v2 import Entity
 from nomad.datamodel.metainfo.plot import PlotlyFigure, PlotSection
@@ -7,6 +9,9 @@
 
 logger = utils.get_logger(__name__)
 
+if TYPE_CHECKING:
+    from nomad.datamodel.metainfo import BoundLogger
+
 
 class PhysicalProperty(PlotSection):
     """
@@ -145,7 +150,7 @@ def _is_contribution(self) -> bool:
                     return True
         return False
 
-    def _validate_contributions_structure(self, logger) -> bool:
+    def _validate_contributions_structure(self, logger: 'BoundLogger') -> bool:
         """
         Validates that contributions do not contain nested contributions.
         This prevents recursive contribution structures which are not intended.

tests/test_physical_properties.py

@@ -1,5 +1,6 @@
 import numpy as np
 import pytest
+from typing import Callable
 from nomad.datamodel import EntryArchive
 from nomad.datamodel.metainfo.plot import PlotlyFigure
 from nomad.metainfo import Quantity
@@ -101,7 +102,7 @@ def test_plotting_and_contributions(self):
         ],
     )
     def test_name_setting_during_normalization(
-        self, instantiator: callable, reference: str
+        self, instantiator: Callable, reference: str
     ):
         """
         Test that the name is set during normalization for PhysicalProperty.