remove attributes with no fields from the non-visited list after removal

Author: lukaspie

src/pynxtools/dataconverter/validation.py

@@ -898,12 +898,18 @@ def check_attributes_of_nonexisting_field(
                         type_of_parent_from_tree == "group"
                         or type_of_parent_from_tree is None
                     ):
-                        keys_to_remove.append(key)
                         collector.collect_and_log(
                             key[0:last_index],
                             ValidationProblem.AttributeForNonExistingField,
                             "attribute",
                         )
+                        collector.collect_and_log(
+                            key,
+                            ValidationProblem.KeyToBeRemoved,
+                            "attribute",
+                        )
+                        keys_to_remove.append(key)
+                        remove_from_not_visited(key)
 
     def check_type_with_tree(
         node: NexusNode,

tests/dataconverter/test_validation.py

@@ -861,7 +861,7 @@ def listify_template(data_dict: Template):
                 {"link": "/my_entry/nxodd_name/char_value"},
             ),
             [],
-            id="base-class-links-with-matching-nexus-types",
+            id="baseclass-links-with-matching-nexus-types",
         ),
         pytest.param(
             alter_dict(
@@ -878,7 +878,7 @@ def listify_template(data_dict: Template):
                 "Field /ENTRY[my_entry]/SAMPLE[my_sample] written without documentation.",
                 "Expected a field at /ENTRY[my_entry]/SAMPLE[my_sample]/name but found a group.",
             ],
-            id="base-class-links-with-wrong-nexus-types",
+            id="baseclass-links-with-wrong-nexus-types",
         ),
         pytest.param(
             alter_dict(
@@ -1340,7 +1340,7 @@ def listify_template(data_dict: Template):
             [
                 "Reserved suffix '_weights' was used in /ENTRY[my_entry]/OPTIONAL_group[my_group]/FIELDNAME_weights[some_random_field_weights], but there is no associated field some_random_field.",
             ],
-            id="reserved-suffix-from-base-class",
+            id="reserved-suffix-from-baseclass",
         ),
         pytest.param(
             alter_dict(