Skip to content

Commit 0bac7c1

Browse files
committed
Fix verbose logging
1 parent e7fdc19 commit 0bac7c1

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

CPAC/pipeline/cpac_pipeline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import copy
2424
import faulthandler
2525

26-
from logging import getLogger
26+
from CPAC.utils.monitoring.custom_logging import getLogger
2727
from time import strftime
2828

2929
import nipype

CPAC/pipeline/engine.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555

5656
from CPAC.resources.templates.lookup_table import lookup_identifier
5757

58-
logger = logging.getLogger('nipype.workflow')
58+
logger = getLogger('nipype.workflow')
5959
verbose_logger = logging.getLogger('engine')
6060

6161

@@ -448,6 +448,7 @@ def get_strats(self, resources, debug=False):
448448
linked_resources = []
449449
resource_list = []
450450
if debug:
451+
verbose_logger = getLogger('engine')
451452
verbose_logger.debug('\nresources: %s', resources)
452453
for resource in resources:
453454
# grab the linked-input tuples
@@ -471,6 +472,7 @@ def get_strats(self, resources, debug=False):
471472
variant_pool = {}
472473
len_inputs = len(resource_list)
473474
if debug:
475+
verbose_logger = getLogger('engine')
474476
verbose_logger.debug('linked_resources: %s',
475477
linked_resources)
476478
verbose_logger.debug('resource_list: %s', resource_list)
@@ -498,6 +500,7 @@ def get_strats(self, resources, debug=False):
498500
f'NO-{val[0]}')
499501

500502
if debug:
503+
verbose_logger = getLogger('engine')
501504
verbose_logger.debug('%s sub_pool: %s\n', resource, sub_pool)
502505
total_pool.append(sub_pool)
503506

@@ -533,6 +536,7 @@ def get_strats(self, resources, debug=False):
533536
strat_list_list.append(strat_list)
534537

535538
if debug:
539+
verbose_logger = getLogger('engine')
536540
verbose_logger.debug('len(strat_list_list): %s\n',
537541
len(strat_list_list))
538542
for strat_list in strat_list_list:
@@ -1320,10 +1324,11 @@ def connect_block(self, wf, cfg, rpool):
13201324
option_val = option_config[-1]
13211325
if option_val in self.grab_tiered_dct(cfg, key_list[:-1]):
13221326
opts.append(option_val)
1323-
else:
1327+
else: # AND, if there are multiple option-val's (in a list) in the docstring, it gets iterated below in 'for opt in option' etc. AND THAT'S WHEN YOU HAVE TO DELINEATE WITHIN THE NODE BLOCK CODE!!!
13241328
opts = [None]
13251329
all_opts += opts
13261330
for name, block_dct in self.node_blocks.items(): # <--- iterates over either the single node block in the sequence, or a list of node blocks within the list of node blocks, i.e. for option forking.
1331+
13271332
switch = self.check_null(block_dct['switch'])
13281333
config = self.check_null(block_dct['config'])
13291334
option_key = self.check_null(block_dct['option_key'])
@@ -1438,6 +1443,7 @@ def connect_block(self, wf, cfg, rpool):
14381443
node_name = f'{node_name}_{opt["Name"]}'
14391444

14401445
if debug:
1446+
verbose_logger = getLogger('engine')
14411447
verbose_logger.debug('\n=======================')
14421448
verbose_logger.debug('Node name: %s', node_name)
14431449
prov_dct = \
@@ -1536,7 +1542,7 @@ def connect_block(self, wf, cfg, rpool):
15361542
new_json_info,
15371543
pipe_idx,
15381544
pipe_x)
1539-
1545+
15401546
return wf
15411547

15421548

@@ -1777,6 +1783,7 @@ def ingress_raw_func_data(wf, rpool, cfg, data_paths, unique_id, part_id,
17771783
# pylint: disable=protected-access
17781784
wf._local_func_scans = local_func_scans
17791785
if cfg.pipeline_setup['Debugging']['verbose']:
1786+
verbose_logger = getLogger('engine')
17801787
verbose_logger.debug('local_func_scans: %s', local_func_scans)
17811788
del local_func_scans
17821789

CPAC/surface/surf_preproc.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from logging import raiseExceptions
2+
from CPAC.utils.monitoring.custom_logging import log_subprocess
23
import os
34
import nipype.interfaces.utility as util
45
from CPAC.utils.interfaces.function import Function
@@ -37,7 +38,6 @@ def run_surface(post_freesurfer_folder,
3738
"""
3839

3940
import os
40-
import subprocess
4141

4242
recon_all_path = os.path.join(freesurfer_folder, 'recon_all')
4343

@@ -54,7 +54,7 @@ def run_surface(post_freesurfer_folder,
5454
'--hiresmesh', high_res_mesh, '--lowresmesh', low_res_mesh, \
5555
'--subcortgraylabels', subcortical_gray_labels, '--freesurferlabels', freesurfer_labels]
5656

57-
subprocess.check_output(cmd)
57+
log_subprocess(cmd)
5858

5959
# DCAN-HCP fMRISurface
6060
# https://github.com/DCAN-Labs/DCAN-HCP/blob/master/fMRISurface/GenericfMRISurfaceProcessingPipeline.sh
@@ -64,7 +64,7 @@ def run_surface(post_freesurfer_folder,
6464
scout_bold, '--lowresmesh', low_res_mesh, '--grayordinatesres',
6565
gray_ordinates_res, '--fmrires', fmri_res, '--smoothingFWHM',
6666
smooth_fwhm]
67-
subprocess.check_output(cmd)
67+
log_subprocess(cmd)
6868

6969
dtseries = os.path.join(post_freesurfer_folder,
7070
'MNINonLinear/Results/task-rest01/'

0 commit comments

Comments
 (0)