Minor fix to load_all_metadata - see HEA-572

rhunwicks · Copilot · web-flow · commit 73b51dd0b454 · 2025-10-15T10:33:48.000-04:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/pipelines/jobs/metadata.py b/pipelines/jobs/metadata.py
@@ -151,7 +151,7 @@ def load_metadata_for_model(context: OpExecutionContext, sheet_name: str, model:
             instances = model.objects.bulk_create(
                 instances,
                 update_conflicts=True,
-                update_fields=[k for k in record if k not in id_fields and k != model._meta.pk.name],
+                update_fields=[k for k in valid_field_names if k not in id_fields and k != model._meta.pk.name],
                 unique_fields=id_fields,
             )
             context.log.info(f"Created or updated {len(instances)} {sheet_name} instances")

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ def load_metadata_for_model(context: OpExecutionContext, sheet_name: str, model:`
`151`	`151`	`instances = model.objects.bulk_create(`
`152`	`152`	`instances,`
`153`	`153`	`update_conflicts=True,`
`154`		`- update_fields=[k for k in record if k not in id_fields and k != model._meta.pk.name],`
	`154`	`+ update_fields=[k for k in valid_field_names if k not in id_fields and k != model._meta.pk.name],`
`155`	`155`	`unique_fields=id_fields,`
`156`	`156`	`)`
`157`	`157`	`context.log.info(f"Created or updated {len(instances)} {sheet_name} instances")`